Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ofbiz.apache.org
Date: Sat, 9 Dec 2017 15:02:00 +0000 (UTC)
From: "Michael Brohl (JIRA)" <jira@apache.org>
To: notifications@ofbiz.apache.org
Message-ID: <JIRA.13104723.1506335621000.424223.1512831720075@Atlassian.JIRA>
In-Reply-To: <JIRA.13104723.1506335621000@Atlassian.JIRA>
References: <JIRA.13104723.1506335621000@Atlassian.JIRA> <JIRA.13104723.1506335621751@jira-lw-us.apache.org>
Subject: [jira] [Closed] (OFBIZ-9775) [FB] Package
 org.apache.ofbiz.product.feature
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sat, 09 Dec 2017 15:02:05 -0000


     [ https://issues.apache.org/jira/browse/OFBIZ-9775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Brohl closed OFBIZ-9775.
--------------------------------
       Resolution: Implemented
    Fix Version/s: Upcoming Release

Thanks Julian,

your patch is in trunk r1817619. 

> [FB] Package org.apache.ofbiz.product.feature
> ---------------------------------------------
>
>                 Key: OFBIZ-9775
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9775
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: Trunk
>            Reporter: Julian Leichert
>            Assignee: Michael Brohl
>            Priority: Minor
>             Fix For: Upcoming Release
>
>         Attachments: OFBIZ-9775_org.apache.ofbiz.product.feature_bugfixes.patch
>
>
> ParametricSearch.java:152, BC_UNCONFIRMED_CAST
> - BC: Unchecked/unconfirmed cast from javax.servlet.ServletRequest to javax.servlet.http.HttpServletRequest in org.apache.ofbiz.product.feature.ParametricSearch.makeFeatureIdByTypeMap(ServletRequest)
> This cast is unchecked, and not all instances of the type casted from can be cast to the type it is being cast to. Check that your program logic ensures that this cast will not fail.
> ProductFeatureServices.java:63, DLS_DEAD_LOCAL_STORE
> - DLS: Dead store to results in org.apache.ofbiz.product.feature.ProductFeatureServices.getProductFeaturesByType(DispatchContext, Map)
> This instruction assigns a value to a local variable, but the value is not read or used in any subsequent instruction. Often, this indicates an error, because the value computed is never used.
> Note that Sun's javac compiler often generates dead stores for final local variables. Because FindBugs is a bytecode-based tool, there is no easy way to eliminate these false positives.
> ProductFeatureServices.java:130, DLS_DEAD_LOCAL_STORE
> - DLS: Dead store to results in org.apache.ofbiz.product.feature.ProductFeatureServices.getAllExistingVariants(DispatchContext, Map)
> This instruction assigns a value to a local variable, but the value is not read or used in any subsequent instruction. Often, this indicates an error, because the value computed is never used.
> Note that Sun's javac compiler often generates dead stores for final local variables. Because FindBugs is a bytecode-based tool, there is no easy way to eliminate these false positives.
> ProductFeatureServices.java:182, DLS_DEAD_LOCAL_STORE
> - DLS: Dead store to results in org.apache.ofbiz.product.feature.ProductFeatureServices.getVariantCombinations(DispatchContext, Map)
> This instruction assigns a value to a local variable, but the value is not read or used in any subsequent instruction. Often, this indicates an error, because the value computed is never used.
> Note that Sun's javac compiler often generates dead stores for final local variables. Because FindBugs is a bytecode-based tool, there is no easy way to eliminate these false positives. 


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)