Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0E728200D46 for ; Sun, 26 Nov 2017 10:34:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 0CF97160C13; Sun, 26 Nov 2017 09:34:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 51C9B160BFA for ; Sun, 26 Nov 2017 10:34:04 +0100 (CET) Received: (qmail 17075 invoked by uid 500); 26 Nov 2017 09:34:03 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 17066 invoked by uid 99); 26 Nov 2017 09:34:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 26 Nov 2017 09:34:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id E89391A0EB4 for ; Sun, 26 Nov 2017 09:34:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id ookeCl79xd3P for ; Sun, 26 Nov 2017 09:34:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E2D2E5F27D for ; Sun, 26 Nov 2017 09:34:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6E6C4E0635 for ; Sun, 26 Nov 2017 09:34:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 21CB02419F for ; Sun, 26 Nov 2017 09:34:00 +0000 (UTC) Date: Sun, 26 Nov 2017 09:34:00 +0000 (UTC) From: "Jacques Le Roux (JIRA)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (OFBIZ-9905) Issue with Agreement under Accounting MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sun, 26 Nov 2017 09:34:05 -0000 [ https://issues.apache.org/jira/browse/OFBIZ-9905?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1626= 5948#comment-16265948 ]=20 Jacques Le Roux commented on OFBIZ-9905: ---------------------------------------- Hi Sourabh, Your patch looks good and this is something which annoyed me as well back i= n the days. I went to an easier/lighter solution see http://svn.apache.org/= viewvc?view=3Drevision&revision=3D829895 bq. I have also modified the content of PageTitleEditAgreement label in Fr= ench (only) because translation of the sole Edit was not enough to give som= e sense. So it was only in French but we could do it in all other languages for all = the screen you mentionned including French if I missed it somewhere, easier= /lighter h=C3=A8 ? > Issue with Agreement under Accounting > ------------------------------------- > > Key: OFBIZ-9905 > URL: https://issues.apache.org/jira/browse/OFBIZ-9905 > Project: OFBiz > Issue Type: Bug > Environment: https://demo-trunk.ofbiz.apache.org/accounting/contr= ol/EditAgreement > Reporter: Aayush jain > Assignee: Jacques Le Roux > Attachments: OFBIZ-9905.patch, UI_label .png > > > Following issues found: > 1. Create Agreement opens an edit agreement window > 2. Able to Create Agreement without any detail (empty Agreement)=20 > Steps: > 1. Open URL https://demo-trunk.ofbiz.apache.org/accounting/control/FindAg= reement > 2. Navigate to Agreement section > 3. Click on create Agreement > 4. Click submit button > Actual: Agreement id is generated for empty agreement and when create win= dow opens, it's redirection is wrong to edit window > Expected: Proper redirection should be there (create agreement) and if an= agreement is created without any details its of no use. > Note: Same Issue exist with following screens: > 1. Billing Account=20 > 2. Tax Authority=20 > 3. Agreement=20 > 4. Fixed Asset=20 > 5. Vendor=20 > 6. WebSite > 7. Blog=20 > 8. Employment > 9. Employee Position=20 > 10.Performance Review =20 > 11.Job Requisition=20 > 12. Party Resume -- This message was sent by Atlassian JIRA (v6.4.14#64029)