Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1CCDF200D37 for ; Thu, 9 Nov 2017 13:32:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 1B675160BEF; Thu, 9 Nov 2017 12:32:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5EF761609E5 for ; Thu, 9 Nov 2017 13:32:03 +0100 (CET) Received: (qmail 46581 invoked by uid 500); 9 Nov 2017 12:32:02 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 46572 invoked by uid 99); 9 Nov 2017 12:32:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Nov 2017 12:32:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id DB7261A3ABE for ; Thu, 9 Nov 2017 12:32:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id AKjpLKvnXZg6 for ; Thu, 9 Nov 2017 12:32:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E21BA61125 for ; Thu, 9 Nov 2017 12:32:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7549DE0D55 for ; Thu, 9 Nov 2017 12:32:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2203623F05 for ; Thu, 9 Nov 2017 12:32:00 +0000 (UTC) Date: Thu, 9 Nov 2017 12:32:00 +0000 (UTC) From: "Jacques Le Roux (JIRA)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Closed] (OFBIZ-8300) Framework: Remove inline js for toggleAll calling from ftls and also remove checkToggle, toggleAll and selectAll js functions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 09 Nov 2017 12:32:04 -0000 [ https://issues.apache.org/jira/browse/OFBIZ-8300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-8300. ---------------------------------- Resolution: Implemented Fix Version/s: Upcoming Release Thanks Amardeep and Aditya, Your patch is in trunk at revision: 1814723 > Framework: Remove inline js for toggleAll calling from ftls and also remove checkToggle, toggleAll and selectAll js functions > ----------------------------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-8300 > URL: https://issues.apache.org/jira/browse/OFBIZ-8300 > Project: OFBiz > Issue Type: Sub-task > Components: framework > Affects Versions: Trunk > Reporter: Amardeep Singh Jhajj > Assignee: Jacques Le Roux > Priority: Minor > Fix For: Upcoming Release > > Attachments: OFBIZ-8300.patch, OFBIZ-8300.patch > > > Remove inline js for toggleAll, checkToggle and selectAll calling from ftls in Framework component. Add class="selectAll" on parent checkbox element for select all functionality. > Also remove js functions from OFBIZUtil.js. Functions are: toggleAll, selectAll, toggle and checkToggle, as all its usage replaced with generic selectAll class usage. -- This message was sent by Atlassian JIRA (v6.4.14#64029)