ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brohl (JIRA)" <j...@apache.org>
Subject [jira] [Created] (OFBIZ-9964) UtilMisc.ensureLocale does not always return a valid Locale
Date Sat, 04 Nov 2017 09:59:00 GMT
Michael Brohl created OFBIZ-9964:
------------------------------------

             Summary: UtilMisc.ensureLocale does not always return a valid Locale
                 Key: OFBIZ-9964
                 URL: https://issues.apache.org/jira/browse/OFBIZ-9964
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: Release Branch 16.11, Trunk
            Reporter: Michael Brohl
            Assignee: Michael Brohl
            Priority: Minor


The Javadoc promises that the function will always retirn a valid Locale, at least a default.
This does not work if a String is provided which cannot be parsed to a valid locale through
the parseLocale function which can return null.


{code:java}
    public static Locale ensureLocale(Object localeObject) {
        if (localeObject instanceof String) {
            return parseLocale((String) localeObject);
        } else if (localeObject instanceof Locale) {
            return (Locale) localeObject;
        }
        return Locale.getDefault();
    }
{code}

I will provide a patch for it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message