ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Le Roux (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (OFBIZ-8341) Fix Default or Empty Catch block in Java and Groovy files
Date Thu, 23 Nov 2017 15:25:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16264465#comment-16264465
] 

Jacques Le Roux edited comment on OFBIZ-8341 at 11/23/17 3:24 PM:
------------------------------------------------------------------

29/Jun/17 13:13 I wrote 
bq. We still have 88 swallowed exceptions in Java and Groovy 
Good news: remain only 58... but still 58...


was (Author: jacques.le.roux):
Ha sorry Akash did not see you assigned yourself. I let you handle the patches :)

Also if you get some time please update https://cwiki.apache.org/confluence/display/OFBIZ/Apache+OFBiz+PMC+Members+and+Committers
for Swapnil (o rask him :D) and yourself. Else I''l do it when I'll get a chance...

> Fix Default or Empty Catch block in Java and Groovy files
> ---------------------------------------------------------
>
>                 Key: OFBIZ-8341
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-8341
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>            Reporter: Harsh Vijaywargiya
>            Assignee: Jacques Le Roux
>             Fix For: Upcoming Release
>
>         Attachments: OFBIZ-8341- OrderReadHelper.patch
>
>
> In many Java and Groovy files we have auto generated catch blocks or empty catch blocks.

> To avoid such exception swallowing this should be improved to at least log the error
and also return error in case of service.
> As of now I found following classes with such patterns - 
> InventoryServices.java
> FreeMarkerWorker.java
> QRCodeEvents.java
> QRCodeServices.java



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message