ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brohl (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (OFBIZ-9686) [FB] Package org.apache.ofbiz.widget.renderer.html
Date Sat, 07 Oct 2017 16:08:01 GMT

     [ https://issues.apache.org/jira/browse/OFBIZ-9686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael Brohl closed OFBIZ-9686.
--------------------------------
       Resolution: Implemented
    Fix Version/s: Upcoming Release

Thanks Julian,

your modified patch is in trunk r1811439.

I additionally removed all commented out code.


> [FB] Package org.apache.ofbiz.widget.renderer.html
> --------------------------------------------------
>
>                 Key: OFBIZ-9686
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9686
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS, ALL COMPONENTS
>            Reporter: Julian Leichert
>            Assignee: Michael Brohl
>            Priority: Minor
>             Fix For: Upcoming Release
>
>         Attachments: OFBIZ-9686_org.apache.ofbiz.widget.renderer.html_bugfixes.patch
>
>
> HtmlMenuRenderer.java:82, UCF_USELESS_CONTROL_FLOW
> - UCF: Useless control flow in org.apache.ofbiz.widget.renderer.html.HtmlMenuRenderer.appendOfbizUrl(Appendable,
String)
> This method contains a useless control flow statement, where control flow continues onto
the same place regardless of whether or not the branch is taken. For example, this is caused
by having an empty statement block for an if statement:
>     if (argv.length == 0) {
>     // TODO: handle this case
>     }
> HtmlMenuRenderer.java:111, UCF_USELESS_CONTROL_FLOW
> - UCF: Useless control flow in org.apache.ofbiz.widget.renderer.html.HtmlMenuRenderer.appendContentUrl(Appendable,
String)
> This method contains a useless control flow statement, where control flow continues onto
the same place regardless of whether or not the branch is taken. For example, this is caused
by having an empty statement block for an if statement:
>     if (argv.length == 0) {
>     // TODO: handle this case
>     }
> HtmlMenuRenderer.java:470, NP_LOAD_OF_KNOWN_NULL_VALUE
> - NP: Load of known null value in org.apache.ofbiz.widget.renderer.html.HtmlMenuRenderer.renderLink(Appendable,
Map, ModelMenuItem$MenuLink)
> The variable referenced at this point is known to be null due to an earlier check against
null. Although this is valid, it might be a mistake (perhaps you intended to refer to a different
variable, or perhaps the earlier check to see if the variable is null should have been a check
to see if it was non-null).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message