ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brohl (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-9626) [FB] Package org.apache.ofbiz.cmssite.multisite
Date Sat, 07 Oct 2017 13:32:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-9626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16195695#comment-16195695
] 

Michael Brohl commented on OFBIZ-9626:
--------------------------------------

Hi Dennis,

this patch does not work. It seems to be derived from a framework repository with the plugins
integrated under /plugins.
Please provide a patch for the plain plugins repository, thanks!

Regards,
Michael

> [FB] Package org.apache.ofbiz.cmssite.multisite
> -----------------------------------------------
>
>                 Key: OFBIZ-9626
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9626
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: cmssite
>    Affects Versions: Trunk
>            Reporter: Dennis Balkir
>            Assignee: Michael Brohl
>            Priority: Minor
>         Attachments: OFBIZ-9629_org.apache.ofbiz.cmssite.multisite_bugfixes.patch
>
>
> - MultiSiteRequestWrapper.java:140, NM_CONFUSING
> Nm: Confusing to have methods org.apache.ofbiz.cmssite.multisite.MultiSiteRequestWrapper.getRequestURI()
and org.apache.ofbiz.webtools.artifactinfo.ControllerRequestArtifactInfo.getRequestUri()
> The referenced methods have names that differ only by capitalization.
> - WebSiteFilter.java:68, BC_UNCONFIRMED_CAST
> BC: Unchecked/unconfirmed cast from javax.servlet.ServletRequest to javax.servlet.http.HttpServletRequest
in org.apache.ofbiz.cmssite.multisite.WebSiteFilter.doFilter(ServletRequest, ServletResponse,
FilterChain)
> This cast is unchecked, and not all instances of the type casted from can be cast to
the type it is being cast to. Check that your program logic ensures that this cast will not
fail.
> - WebSiteFilter.java:69, BC_UNCONFIRMED_CAST
> BC: Unchecked/unconfirmed cast from javax.servlet.ServletResponse to javax.servlet.http.HttpServletResponse
in org.apache.ofbiz.cmssite.multisite.WebSiteFilter.doFilter(ServletRequest, ServletResponse,
FilterChain)
> This cast is unchecked, and not all instances of the type casted from can be cast to
the type it is being cast to. Check that your program logic ensures that this cast will not
fail.
> - WebSiteFilter.java:83, NP_LOAD_OF_KNOWN_NULL_VALUE
> NP: Load of known null value in org.apache.ofbiz.cmssite.multisite.WebSiteFilter.doFilter(ServletRequest,
ServletResponse, FilterChain)
> The variable referenced at this point is known to be null due to an earlier check against
null. Although this is valid, it might be a mistake (perhaps you intended to refer to a different
variable, or perhaps the earlier check to see if the variable is null should have been a check
to see if it was non-null).
> - WebSiteFilter.java:83, RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE
> RCN: Redundant nullcheck of webSite which is known to be null in org.apache.ofbiz.cmssite.multisite.WebSiteFilter.doFilter(ServletRequest,
ServletResponse, FilterChain)
> This method contains a redundant check of a known null value against the constant null.
> - WebSiteFilter.java:161, J2EE_STORE_OF_NON_SERIALIZABLE_OBJECT_INTO_SESSION
> J2EE: Store of non serializable org.apache.ofbiz.entity.Delegator into HttpSession in
org.apache.ofbiz.cmssite.multisite.WebSiteFilter.setWebContextObjects(HttpServletRequest,
HttpServletResponse, Delegator, LocalDispatcher)
> This code seems to be storing a non-serializable object into an HttpSession. If this
session is passivated or migrated, an error will result.
> - WebSiteFilter.java:162, J2EE_STORE_OF_NON_SERIALIZABLE_OBJECT_INTO_SESSION
> J2EE: Store of non serializable org.apache.ofbiz.service.LocalDispatcher into HttpSession
in org.apache.ofbiz.cmssite.multisite.WebSiteFilter.setWebContextObjects(HttpServletRequest,
HttpServletResponse, Delegator, LocalDispatcher)
> This code seems to be storing a non-serializable object into an HttpSession. If this
session is passivated or migrated, an error will result.
> - WebSiteFilter.java:163, J2EE_STORE_OF_NON_SERIALIZABLE_OBJECT_INTO_SESSION
> J2EE: Store of non serializable org.apache.ofbiz.security.Security into HttpSession in
org.apache.ofbiz.cmssite.multisite.WebSiteFilter.setWebContextObjects(HttpServletRequest,
HttpServletResponse, Delegator, LocalDispatcher)
> This code seems to be storing a non-serializable object into an HttpSession. If this
session is passivated or migrated, an error will result.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message