Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 32778200D08 for ; Thu, 21 Sep 2017 14:40:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 310211609D0; Thu, 21 Sep 2017 12:40:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 76E521609B8 for ; Thu, 21 Sep 2017 14:40:03 +0200 (CEST) Received: (qmail 37321 invoked by uid 500); 21 Sep 2017 12:40:02 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 37308 invoked by uid 99); 21 Sep 2017 12:40:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Sep 2017 12:40:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 1927F18E455 for ; Thu, 21 Sep 2017 12:40:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Q6kYqhpxbQMl for ; Thu, 21 Sep 2017 12:40:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id CF89F60D99 for ; Thu, 21 Sep 2017 12:40:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 58210E02C7 for ; Thu, 21 Sep 2017 12:40:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 102152190D for ; Thu, 21 Sep 2017 12:40:00 +0000 (UTC) Date: Thu, 21 Sep 2017 12:40:00 +0000 (UTC) From: "Julian Leichert (JIRA)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (OFBIZ-9735) [FB] Package org.apache.ofbiz.party.contact MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 21 Sep 2017 12:40:04 -0000 Julian Leichert created OFBIZ-9735: -------------------------------------- Summary: [FB] Package org.apache.ofbiz.party.contact Key: OFBIZ-9735 URL: https://issues.apache.org/jira/browse/OFBIZ-9735 Project: OFBiz Issue Type: Sub-task Components: party Affects Versions: Trunk Reporter: Julian Leichert Priority: Minor ContactMechServices.java:508, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE - RCN: Redundant nullcheck of relatedEntityToSet, which is known to be non-null in org.apache.ofbiz.party.contact.ContactMechServices.updatePostalAddress(DispatchContext, Map) This method contains a redundant check of a known non-null value against the constant null. ContactMechServices.java:710, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE - RCN: Redundant nullcheck of relatedEntityToSet, which is known to be non-null in org.apache.ofbiz.party.contact.ContactMechServices.updateTelecomNumber(DispatchContext, Map) This method contains a redundant check of a known non-null value against the constant null. ContactMechServices.java:1064, DM_DEFAULT_ENCODING - Dm: Found reliance on default encoding in org.apache.ofbiz.party.contact.ContactMechServices.createEmailAddressVerification(DispatchContext, Map): String.getBytes() Found a call to a method which will perform a byte to String (or String to byte) conversion, and will assume that the default platform encoding is suitable. This will cause the application behaviour to vary between platforms. Use an alternative API and specify a charset name or Charset object explicitly. ContactMechWorker.java:825, DM_CONVERT_CASE - Dm: Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.ofbiz.party.contact.ContactMechWorker.isUspsAddress(GenericValue) A String is being converted to upper or lowercase, using the platform's default encoding. This may result in improper conversions when used with international characters. Use the String.toUpperCase( Locale l ) String.toLowerCase( Locale l ) versions instead. ContactMechWorker.java:854, DM_CONVERT_CASE - Dm: Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.ofbiz.party.contact.ContactMechWorker.isCompanyAddress(GenericValue, String) A String is being converted to upper or lowercase, using the platform's default encoding. This may result in improper conversions when used with international characters. Use the String.toUpperCase( Locale l ) String.toLowerCase( Locale l ) versions instead. ContactMechWorker.java:889, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE - RCN: Redundant nullcheck of postalAddresses, which is known to be non-null in org.apache.ofbiz.party.contact.ContactMechWorker.isCompanyAddress(GenericValue, String) This method contains a redundant check of a known non-null value against the constant null. -- This message was sent by Atlassian JIRA (v6.4.14#64029)