ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julian Leichert (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (OFBIZ-9775) [FB] Package org.apache.ofbiz.product.feature
Date Mon, 25 Sep 2017 10:36:00 GMT

     [ https://issues.apache.org/jira/browse/OFBIZ-9775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Julian Leichert updated OFBIZ-9775:
-----------------------------------
    Attachment: OFBIZ-9775_org.apache.ofbiz.product.feature_bugfixes.patch

class ProductFeatureServices
 - line 63,130,182 : removed dls


> [FB] Package org.apache.ofbiz.product.feature
> ---------------------------------------------
>
>                 Key: OFBIZ-9775
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9775
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: Trunk
>            Reporter: Julian Leichert
>            Priority: Minor
>         Attachments: OFBIZ-9775_org.apache.ofbiz.product.feature_bugfixes.patch
>
>
> ParametricSearch.java:152, BC_UNCONFIRMED_CAST
> - BC: Unchecked/unconfirmed cast from javax.servlet.ServletRequest to javax.servlet.http.HttpServletRequest
in org.apache.ofbiz.product.feature.ParametricSearch.makeFeatureIdByTypeMap(ServletRequest)
> This cast is unchecked, and not all instances of the type casted from can be cast to
the type it is being cast to. Check that your program logic ensures that this cast will not
fail.
> ProductFeatureServices.java:63, DLS_DEAD_LOCAL_STORE
> - DLS: Dead store to results in org.apache.ofbiz.product.feature.ProductFeatureServices.getProductFeaturesByType(DispatchContext,
Map)
> This instruction assigns a value to a local variable, but the value is not read or used
in any subsequent instruction. Often, this indicates an error, because the value computed
is never used.
> Note that Sun's javac compiler often generates dead stores for final local variables.
Because FindBugs is a bytecode-based tool, there is no easy way to eliminate these false positives.
> ProductFeatureServices.java:130, DLS_DEAD_LOCAL_STORE
> - DLS: Dead store to results in org.apache.ofbiz.product.feature.ProductFeatureServices.getAllExistingVariants(DispatchContext,
Map)
> This instruction assigns a value to a local variable, but the value is not read or used
in any subsequent instruction. Often, this indicates an error, because the value computed
is never used.
> Note that Sun's javac compiler often generates dead stores for final local variables.
Because FindBugs is a bytecode-based tool, there is no easy way to eliminate these false positives.
> ProductFeatureServices.java:182, DLS_DEAD_LOCAL_STORE
> - DLS: Dead store to results in org.apache.ofbiz.product.feature.ProductFeatureServices.getVariantCombinations(DispatchContext,
Map)
> This instruction assigns a value to a local variable, but the value is not read or used
in any subsequent instruction. Often, this indicates an error, because the value computed
is never used.
> Note that Sun's javac compiler often generates dead stores for final local variables.
Because FindBugs is a bytecode-based tool, there is no easy way to eliminate these false positives.




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message