ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julian Leichert (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (OFBIZ-9684) [FB] Package org.apache.ofbiz.service.group
Date Thu, 07 Sep 2017 12:40:00 GMT

     [ https://issues.apache.org/jira/browse/OFBIZ-9684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Julian Leichert updated OFBIZ-9684:
-----------------------------------
    Attachment: OFBIZ-9684_org.apache.ofbiz.service.group_bugfixes.patch

- Added Diamond Operators

class GroupModel
 - changed null check to isEmpty

class GroupServiceModel
 - removed redundant null check

class ServiceGroupReader
 - changed public static to public static final
 - changed null check to isEmpty



> [FB] Package org.apache.ofbiz.service.group
> -------------------------------------------
>
>                 Key: OFBIZ-9684
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9684
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS, ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Julian Leichert
>            Priority: Minor
>         Attachments: OFBIZ-9684_org.apache.ofbiz.service.group_bugfixes.patch
>
>
> GroupModel.java:55, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE
> - RCN: Redundant nullcheck of org.apache.ofbiz.service.group.GroupModel.groupName, which
is known to be non-null in new org.apache.ofbiz.service.group.GroupModel(Element)
> This method contains a redundant check of a known non-null value against the constant
null.
> GroupServiceModel.java:107, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE
> - RCN: Redundant nullcheck of model, which is known to be non-null in org.apache.ofbiz.service.group.GroupServiceModel.invoke(ServiceDispatcher,
String, Map)
> This method contains a redundant check of a known non-null value against the constant
null.
> ServiceGroupReader.java:43, MS_SHOULD_BE_FINAL, Priorit├Ąt: Hoch
> - MS: org.apache.ofbiz.service.group.ServiceGroupReader.groupsCache isn't final but should
be
> This static field public but not final, and could be changed by malicious code or by
accident from another package. The field could be made final to avoid this vulnerability.
> ServiceGroupReader.java:78, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE
> - RCN: Redundant nullcheck of groupName, which is known to be non-null in org.apache.ofbiz.service.group.ServiceGroupReader.addGroupDefinitions(ResourceHandler)
> This method contains a redundant check of a known non-null value against the constant
null.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message