Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6F9E72004F1 for ; Wed, 30 Aug 2017 18:07:06 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6E0DC16962E; Wed, 30 Aug 2017 16:07:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B6E7E16962A for ; Wed, 30 Aug 2017 18:07:05 +0200 (CEST) Received: (qmail 51999 invoked by uid 500); 30 Aug 2017 16:07:04 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 51988 invoked by uid 99); 30 Aug 2017 16:07:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Aug 2017 16:07:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 757DCC19E7 for ; Wed, 30 Aug 2017 16:07:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id pXV5TkzBw-NC for ; Wed, 30 Aug 2017 16:07:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 974125F6C3 for ; Wed, 30 Aug 2017 16:07:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5FB86E0D57 for ; Wed, 30 Aug 2017 16:07:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id B2DC12416C for ; Wed, 30 Aug 2017 16:07:00 +0000 (UTC) Date: Wed, 30 Aug 2017 16:07:00 +0000 (UTC) From: "Rohit Rai (JIRA)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (OFBIZ-9607) Use from-field pattern instead of value=${***} pattern in 'set' element MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 30 Aug 2017 16:07:06 -0000 [ https://issues.apache.org/jira/browse/OFBIZ-9607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Rai updated OFBIZ-9607: ----------------------------- Attachment: OFBIZ-9607_Typo_Content.patch Hi Deepak, While testing this I stumbled upon a typo in the previous patch. I am uploading the correct patch. Sorry for the inconvenience. > Use from-field pattern instead of value=${***} pattern in 'set' element > ----------------------------------------------------------------------- > > Key: OFBIZ-9607 > URL: https://issues.apache.org/jira/browse/OFBIZ-9607 > Project: OFBiz > Issue Type: Improvement > Reporter: Suraj Khurana > Assignee: Rohit Rai > Fix For: Upcoming Release > > Attachments: OFBIZ-9607_Accounting.patch, OFBIZ-9607_AssetMaint.patch, OFBIZ-9607_BI.patch, OFBIZ-9607_BIRT.patch, OFBIZ-9607-CommonExt.patch, OFBIZ-9607_Content.patch, OFBIZ-9607_Ebay_Store.patch, OFBIZ-9607_Ecommerce.patch, OFBIZ-9607_Example.patch, OFBIZ-9607_Framework.patch, OFBIZ-9607_HHFacility.patch, OFBIZ-9607_HR.patch, OFBIZ-9607_Manufacturing.patch, OFBIZ-9607_Marketing.patch, OFBIZ-9607_MyPortal.patch, OFBIZ-9607_Order.patch, OFBIZ-9607_Party.patch, OFBIZ-9607_PriCat.patch, OFBIZ-9607_Product.patch, OFBIZ-9607_ProjectMgr.patch, OFBIZ-9607_Scrum.patch, OFBIZ-9607_Solr.patch, OFBIZ-9607_Themes.patch, OFBIZ-9607_Typo_Content.patch, OFBIZ-9607_WebPos.patch, OFBIZ-9607_Workeffort.patch > > > Currently, there are many occurrences in the code base where we use value=${***} pattern to assign the value to some variable. > Instead of this, we should use from-field for better performance. -- This message was sent by Atlassian JIRA (v6.4.14#64029)