Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D62EA20049B for ; Mon, 14 Aug 2017 21:59:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D48EC165C07; Mon, 14 Aug 2017 19:59:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2F04B165C04 for ; Mon, 14 Aug 2017 21:59:04 +0200 (CEST) Received: (qmail 85773 invoked by uid 500); 14 Aug 2017 19:59:02 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 85519 invoked by uid 99); 14 Aug 2017 19:59:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Aug 2017 19:59:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 725B1C01E1 for ; Mon, 14 Aug 2017 19:59:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 3j7UKBXDq9Ay for ; Mon, 14 Aug 2017 19:59:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 30A735F24E for ; Mon, 14 Aug 2017 19:59:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7CD2CE08F4 for ; Mon, 14 Aug 2017 19:59:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3A3F82140D for ; Mon, 14 Aug 2017 19:59:00 +0000 (UTC) Date: Mon, 14 Aug 2017 19:59:00 +0000 (UTC) From: "JC (JIRA)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (OFBIZ-9578) Collection added to itself MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 14 Aug 2017 19:59:05 -0000 JC created OFBIZ-9578: ------------------------- Summary: Collection added to itself Key: OFBIZ-9578 URL: https://issues.apache.org/jira/browse/OFBIZ-9578 Project: OFBiz Issue Type: Bug Components: framework Reporter: JC Priority: Trivial Hi In a recent github mirror, I've found suspicious code. Branch: master path: framework/entity/src/main/java/org/apache/ofbiz/entity/jdbc/DatabaseUtil.java {code:java} ... 1588 protected final List messages = new LinkedList(); ... 1596 protected int updateData(Collection messages) { 1597 if (messages != null && UtilValidate.isNotEmpty(this.messages)) { 1598 messages.addAll(messages); 1599 } 1600 return count; 1601 } 1602 } {code} In Line 1598, `messages.addAll' should be `this.messages.addAll'? This might not be an issue but I wanted to report this just in case. Thanks! -- This message was sent by Atlassian JIRA (v6.4.14#64029)