Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ofbiz.apache.org
Date: Thu, 10 Aug 2017 07:42:01 +0000 (UTC)
From: "Jacques Le Roux (JIRA)" <jira@apache.org>
To: notifications@ofbiz.apache.org
Message-ID: <JIRA.13093690.1502349985000.135733.1502350921546@Atlassian.JIRA>
In-Reply-To: <JIRA.13093690.1502349985000@Atlassian.JIRA>
References: <JIRA.13093690.1502349985000@Atlassian.JIRA> <JIRA.13093690.1502349985362@jira-lw-us.apache.org>
Subject: [jira] [Assigned] (OFBIZ-9566) [FB] Package
 org.apache.ofbiz.base.config
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Thu, 10 Aug 2017 07:42:10 -0000


     [ https://issues.apache.org/jira/browse/OFBIZ-9566?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-9566:
--------------------------------------

    Assignee: Jacques Le Roux

> [FB] Package org.apache.ofbiz.base.config
> -----------------------------------------
>
>                 Key: OFBIZ-9566
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9566
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: base
>    Affects Versions: Trunk
>            Reporter: Tobias Laufk=C3=B6tter
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-9566.patch
>
>
> FileLoader.java:30, SE_NO_SERIALVERSIONID,
> SnVI: org.apache.ofbiz.base.config.FileLoader is Serializable; consider d=
eclaring a serialVersionUID
> This class implements the Serializable interface, but does not define a s=
erialVersionUID field.  A change as simple as adding a reference to a .clas=
s object will add synthetic fields to the class, which will unfortunately c=
hange the implicit serialVersionUID (e.g., adding a reference to String.cla=
ss will generate a static field class$java$lang$String). Also, different so=
urce code to bytecode compilers may use different naming conventions for sy=
nthetic variables generated for references to class objects or inner classe=
s. To ensure interoperability of Serializable across versions, consider add=
ing an explicit serialVersionUID.
> MainResourceHandler.java:-1, CI_CONFUSED_INHERITANCE,
> CI: Class org.apache.ofbiz.base.config.MainResourceHandler is final but d=
eclares protected field org.apache.ofbiz.base.config.MainResourceHandler.xm=
lFilename
> This class is declared to be final, but declares fields to be protected. =
Since the class is final, it can not be derived from, and the use of protec=
ted is confusing. The access modifier for the field should be changed to pr=
ivate or public to represent the true use for the field.
> MainResourceHandler.java:-1, CI_CONFUSED_INHERITANCE,
> CI: Class org.apache.ofbiz.base.config.MainResourceHandler is final but d=
eclares protected field org.apache.ofbiz.base.config.MainResourceHandler.lo=
cation
> This class is declared to be final, but declares fields to be protected. =
Since the class is final, it can not be derived from, and the use of protec=
ted is confusing. The access modifier for the field should be changed to pr=
ivate or public to represent the true use for the field.
> MainResourceHandler.java:-1, CI_CONFUSED_INHERITANCE,
> CI: Class org.apache.ofbiz.base.config.MainResourceHandler is final but d=
eclares protected field org.apache.ofbiz.base.config.MainResourceHandler.lo=
aderName
> This class is declared to be final, but declares fields to be protected. =
Since the class is final, it can not be derived from, and the use of protec=
ted is confusing. The access modifier for the field should be changed to pr=
ivate or public to represent the true use for the field.
> MainResourceHandler.java:37, SE_NO_SERIALVERSIONID,
> SnVI: org.apache.ofbiz.base.config.MainResourceHandler is Serializable; c=
onsider declaring a serialVersionUID
> This class implements the Serializable interface, but does not define a s=
erialVersionUID field.  A change as simple as adding a reference to a .clas=
s object will add synthetic fields to the class, which will unfortunately c=
hange the implicit serialVersionUID (e.g., adding a reference to String.cla=
ss will generate a static field class$java$lang$String). Also, different so=
urce code to bytecode compilers may use different naming conventions for sy=
nthetic variables generated for references to class objects or inner classe=
s. To ensure interoperability of Serializable across versions, consider add=
ing an explicit serialVersionUID.
> ResourceLoader.java:159, REC_CATCH_EXCEPTION,
> REC: Exception is caught when Exception is not thrown in org.apache.ofbiz=
.base.config.ResourceLoader.makeLoader(Element)
> This method uses a try-catch block that catches Exception objects, but Ex=
ception is not thrown within the try block, and RuntimeException is not exp=
licitly caught. It is a common bug pattern to say try { ... } catch (Except=
ion e) { something } as a shorthand for catching a number of types of excep=
tion each of whose catch blocks is identical, but this construct also accid=
entally catches RuntimeException as well, masking potential bugs.
> A better approach is to either explicitly catch the specific exceptions t=
hat are thrown, or to explicitly catch RuntimeException exception, rethrow =
it, and then catch all non-Runtime Exceptions, as shown below:
>   try {
>     ...
>   } catch (RuntimeException e) {
>     throw e;
>   } catch (Exception e) {
>     ... deal with all non-runtime exceptions ...
>   }
> UrlLoader.java:30, SE_NO_SERIALVERSIONID,
> SnVI: org.apache.ofbiz.base.config.UrlLoader is Serializable; consider de=
claring a serialVersionUID
> This class implements the Serializable interface, but does not define a s=
erialVersionUID field.  A change as simple as adding a reference to a .clas=
s object will add synthetic fields to the class, which will unfortunately c=
hange the implicit serialVersionUID (e.g., adding a reference to String.cla=
ss will generate a static field class$java$lang$String). Also, different so=
urce code to bytecode compilers may use different naming conventions for sy=
nthetic variables generated for references to class objects or inner classe=
s. To ensure interoperability of Serializable across versions, consider add=
ing an explicit serialVersionUID.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)