Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6F0C2200D0D for ; Fri, 25 Aug 2017 21:07:06 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6DBE416D17B; Fri, 25 Aug 2017 19:07:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B472916D179 for ; Fri, 25 Aug 2017 21:07:05 +0200 (CEST) Received: (qmail 89014 invoked by uid 500); 25 Aug 2017 19:07:04 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 89004 invoked by uid 99); 25 Aug 2017 19:07:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Aug 2017 19:07:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 366A71A1B0B for ; Fri, 25 Aug 2017 19:07:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id aZFybuF0hcWS for ; Fri, 25 Aug 2017 19:07:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 85C5C619B6 for ; Fri, 25 Aug 2017 19:07:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 126B9E0E3D for ; Fri, 25 Aug 2017 19:07:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 46E862538A for ; Fri, 25 Aug 2017 19:07:00 +0000 (UTC) Date: Fri, 25 Aug 2017 19:07:00 +0000 (UTC) From: "Deepak Dixit (JIRA)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (OFBIZ-9138) Create a common theme MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 25 Aug 2017 19:07:06 -0000 [ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16142046#comment-16142046 ] Deepak Dixit edited comment on OFBIZ-9138 at 8/25/17 7:06 PM: -------------------------------------------------------------- Fixed COMMON theme id display issue, removed the visualThemeSetId from COMMON theme at r#1806216 was (Author: deepak.dixit): Fixed COMMON theme id display issue, removed the visualThemeSetId from COMMON theme. > Create a common theme > --------------------- > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework > Reporter: Nicolas Malin > Assignee: Nicolas Malin > Attachments: common-theme-macro.svg, common-theme-screen.svg > > > A first task to UI Improvement would be create a common that receive the existent code. > The benefice would be have a framework/common who list all screens that available for theme surcharge, so without technology information (css/html or something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for html rendering instead of framework/common, framework/images and framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)