ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dennis Balkir (JIRA)" <j...@apache.org>
Subject [jira] [Created] (OFBIZ-9640) [FB] Package org.apache.ofbiz.common.preferences
Date Fri, 25 Aug 2017 14:56:00 GMT
Dennis Balkir created OFBIZ-9640:
------------------------------------

             Summary: [FB] Package org.apache.ofbiz.common.preferences
                 Key: OFBIZ-9640
                 URL: https://issues.apache.org/jira/browse/OFBIZ-9640
             Project: OFBiz
          Issue Type: Sub-task
          Components: framework
    Affects Versions: Trunk
            Reporter: Dennis Balkir
            Priority: Minor


- PreferenceWorker.java:90, RpC_REPEATED_CONDITIONAL_TEST
RpC: Repeated conditional test in org.apache.ofbiz.common.preferences.PreferenceWorker.checkCopyPermission(DispatchContext,
Map)

The code contains a conditional test is performed twice, one right after the other (e.g.,
x == 0 || x == 0). Perhaps the second occurrence is intended to be something else (e.g., x
== 0 || y == 0).

- PreferenceWorker.java:90, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE
RCN: Redundant nullcheck of userLoginIdArg, which is known to be non-null in org.apache.ofbiz.common.preferences.PreferenceWorker.checkCopyPermission(DispatchContext,
Map)

This method contains a redundant check of a known non-null value against the constant null.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message