ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dennis Balkir (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (OFBIZ-9636) Incomplete RoleMember Permission Checks for ROLE_MEMBER in evalRoleMember
Date Fri, 25 Aug 2017 14:00:01 GMT

     [ https://issues.apache.org/jira/browse/OFBIZ-9636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Dennis Balkir updated OFBIZ-9636:
---------------------------------
    Attachment: OFBIZ-9636_incomplete-role-member-evaluation-method.patch

class ModelPermission:
- removed method {{evalRoleMember}}; it was mostly useless, and just returned false every
time is was called (it got changed by jaz in 2009, since then it doesn’t do anything except
returning false, and since it wasn’t used that long and nobody seemed to need it for 8 years,
I decided to remove it and all of its calls completely)
-  removed the case with permissionType {{ROLE_MEMBER}} in {{evalPermission}}
- removed the static parameter {{ROLE_MEMBER}}

class ModelServiceReader:
- removed the part for creating the role-member permissions in {{createGroupPermissions}}


> Incomplete RoleMember Permission Checks for ROLE_MEMBER in evalRoleMember
> -------------------------------------------------------------------------
>
>                 Key: OFBIZ-9636
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9636
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Dennis Balkir
>            Priority: Minor
>         Attachments: OFBIZ-9636_incomplete-role-member-evaluation-method.patch
>
>
> incomplete method {{evalRoleMember(GenericValue userLogin)}} which results in this method
always and only returning false. This method was last changed by jaz in the year 2009.
> I am deleting the method and all of its calls, because it obviously is never used, since
its last changes are very long ago and since then its kind of useless
> PS: you cannot choose package service, when creating new issues



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message