ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Le Roux (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (OFBIZ-9578) Collection added to itself
Date Wed, 16 Aug 2017 07:47:00 GMT

     [ https://issues.apache.org/jira/browse/OFBIZ-9578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jacques Le Roux closed OFBIZ-9578.
----------------------------------
       Resolution: Fixed
    Fix Version/s: Release Branch 14.12
                   Release Branch 15.12
                   16.11.04

Thanks JC for the report.

Indeed, that's a bug. 

Fortunately it's only a counter used to log messages. So we only missed the following messages:
{quote}
Reviewed x primary key fields from database. (When OFBiz starts and when using the webtools
checkDb feature)
==== TOTAL Foreign Key Indices Created: (When using the webtools checkDb feature and creating
FKs)
==== TOTAL Declared Indices Created: (When using the webtools checkDb feature and creating
indices)
{quote}
They were no impacts on the DB.

I fixed the bug in
trunk r1805143  
R16.11 r1805144
R15.12 & R14.12 r1805145


> Collection added to itself
> --------------------------
>
>                 Key: OFBIZ-9578
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9578
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: JC
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: 16.11.04, Release Branch 15.12, Release Branch 14.12
>
>
> Hi
> In a recent github mirror, I've found suspicious code.
> Branch: master
> path: framework/entity/src/main/java/org/apache/ofbiz/entity/jdbc/DatabaseUtil.java
> {code:java}
> ...
> 1588         protected final List<String> messages = new LinkedList<String>();
> ...
> 1596         protected int updateData(Collection<String> messages) {
> 1597             if (messages != null && UtilValidate.isNotEmpty(this.messages))
{
> 1598                 messages.addAll(messages);
> 1599             }
> 1600             return count;
> 1601         }
> 1602     }
> {code}
> In Line 1598, `messages.addAll' should be `this.messages.addAll'? This might not be an
issue but I wanted to report this just in case.
> Thanks!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message