ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "JC (JIRA)" <j...@apache.org>
Subject [jira] [Created] (OFBIZ-9578) Collection added to itself
Date Mon, 14 Aug 2017 19:59:00 GMT
JC created OFBIZ-9578:
-------------------------

             Summary: Collection added to itself
                 Key: OFBIZ-9578
                 URL: https://issues.apache.org/jira/browse/OFBIZ-9578
             Project: OFBiz
          Issue Type: Bug
          Components: framework
            Reporter: JC
            Priority: Trivial


Hi

In a recent github mirror, I've found suspicious code.
Branch: master
path: framework/entity/src/main/java/org/apache/ofbiz/entity/jdbc/DatabaseUtil.java


{code:java}
...
1588         protected final List<String> messages = new LinkedList<String>();
...
1596         protected int updateData(Collection<String> messages) {
1597             if (messages != null && UtilValidate.isNotEmpty(this.messages)) {
1598                 messages.addAll(messages);
1599             }
1600             return count;
1601         }
1602     }
{code}

In Line 1598, `messages.addAll' should be `this.messages.addAll'? This might not be an issue
but I wanted to report this just in case.

Thanks!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message