ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dennis Balkir (JIRA)" <j...@apache.org>
Subject [jira] [Created] (OFBIZ-9574) [FB] Package org.apache.ofbiz.base.test
Date Mon, 14 Aug 2017 13:04:00 GMT
Dennis Balkir created OFBIZ-9574:
------------------------------------

             Summary: [FB] Package org.apache.ofbiz.base.test
                 Key: OFBIZ-9574
                 URL: https://issues.apache.org/jira/browse/OFBIZ-9574
             Project: OFBiz
          Issue Type: Sub-task
          Components: base
    Affects Versions: Trunk
            Reporter: Dennis Balkir
            Priority: Minor


- GenericTestCaseBase.java:47, UC_USELESS_OBJECT
Useless object created

Our analysis shows that this object is useless. It's created and modified, but its value never
go outside of the method or produce any side-effect. Either there is a mistake and object
was intended to be used or it can be removed.

This analysis rarely produces false-positives. Common false-positive cases include:

- This object used to implicitly throw some obscure exception.

- This object used as a stub to generalize the code.

- This object used to hold strong references to weak/soft-referenced objects.

- GenericTestCaseBase.java:99, NP_LOAD_OF_KNOWN_NULL_VALUE
NP: Load of known null value in org.apache.ofbiz.base.test.GenericTestCaseBase.assertNotEquals(String,
Object, Object)

The variable referenced at this point is known to be null due to an earlier check against
null. Although this is valid, it might be a mistake (perhaps you intended to refer to a different
variable, or perhaps the earlier check to see if the variable is null should have been a check
to see if it was non-null).

- GenericTestCaseBase.java:99, NP_LOAD_OF_KNOWN_NULL_VALUE
NP: Load of known null value in org.apache.ofbiz.base.test.GenericTestCaseBase.assertNotEquals(String,
Object, Object)

The variable referenced at this point is known to be null due to an earlier check against
null. Although this is valid, it might be a mistake (perhaps you intended to refer to a different
variable, or perhaps the earlier check to see if the variable is null should have been a check
to see if it was non-null).

- GenericTestCaseBase.java:327, NP_LOAD_OF_KNOWN_NULL_VALUE
NP: Load of known null value in org.apache.ofbiz.base.test.GenericTestCaseBase.assertEquals(String,
Object, Object)

The variable referenced at this point is known to be null due to an earlier check against
null. Although this is valid, it might be a mistake (perhaps you intended to refer to a different
variable, or perhaps the earlier check to see if the variable is null should have been a check
to see if it was non-null).

- GenericTestCaseBase.java:334, NP_LOAD_OF_KNOWN_NULL_VALUE
NP: Load of known null value in org.apache.ofbiz.base.test.GenericTestCaseBase.assertEquals(String,
Object, Object)

The variable referenced at this point is known to be null due to an earlier check against
null. Although this is valid, it might be a mistake (perhaps you intended to refer to a different
variable, or perhaps the earlier check to see if the variable is null should have been a check
to see if it was non-null).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message