ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dennis Balkir (JIRA)" <j...@apache.org>
Subject [jira] [Created] (OFBIZ-9567) [FB] Package org.apache.ofbiz.base.metrics
Date Thu, 10 Aug 2017 07:54:00 GMT
Dennis Balkir created OFBIZ-9567:
------------------------------------

             Summary: [FB] Package org.apache.ofbiz.base.metrics
                 Key: OFBIZ-9567
                 URL: https://issues.apache.org/jira/browse/OFBIZ-9567
             Project: OFBiz
          Issue Type: Sub-task
          Components: base
    Affects Versions: Trunk
            Reporter: Dennis Balkir
            Priority: Minor


- MetricsFactory.java:236, ICAST_IDIV_CAST_TO_DOUBLE
ICAST: Integral division result cast to double or float in org.apache.ofbiz.base.metrics.MetricsFactory$MetricsImpl.recordServiceRate(int,
long)

This code casts the result of an integral division (e.g., int or long division) operation
to double or float. Doing division on integers truncates the result to the integer value closest
to zero. The fact that the result was cast to double suggests that this precision should have
been retained. What was probably meant was to cast one or both of the operands to double before
performing the division. Here is an example:

int x = 2;
int y = 5;
// Wrong: yields result 0.0
double value1 =  x / y;

// Right: yields result 0.4
double value2 =  x / (double) y;



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message