ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Le Roux (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-9441) Refactor OFBiz containers and remove StartupCommandToArgsAdapter
Date Fri, 04 Aug 2017 07:27:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-9441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114045#comment-16114045

Jacques Le Roux commented on OFBIZ-9441:

HI Taher,

I remember now, what refrained me to review is that it's not clear which is the last patch

I understand there are 2 different patches
#  OFBIZ-9411.patch
#  OFBIZ-9441-fix-continue-on-failure.patch
And that the last OFBIZ-9411.patch is from 21/Jul/17 16:14. 

But patches are weirdly grayed so I'm (a bit) unsure and especially I'd like to understand
why it's so. 

Also is now the OFBIZ-9441-fix-continue-on-failure.patch included in the last OFBIZ-9411.patch?


> Refactor OFBiz containers and remove StartupCommandToArgsAdapter
> ----------------------------------------------------------------
>                 Key: OFBIZ-9441
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9441
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Taher Alkhateeb
>            Assignee: Taher Alkhateeb
>            Priority: Minor
>         Attachments: OFBIZ-9411.patch, OFBIZ-9441-fix-continue-on-failure.patch, OFBIZ-9441.patch,
OFBIZ-9441.patch, OFBIZ-9441.patch
> We have already refactored the ComponentContainer and CatalinaContainer in OFBIZ-8337
and OFBIZ-9392. The objective of this JIRA is to apply the following:
> - Refactor EntityDataLoadContainer to simplify the code and remove dependencies on "args"
and convert instead the logic to use StartupCommands
> - Refactor TestRunContainer the same way
> - Delete the class StartupCommandToArgsAdapter
> - Update README.md to reflect the changes and updates and cleanup old references.

This message was sent by Atlassian JIRA

View raw message