ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aditya Sharma (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (OFBIZ-9351) Remove unnecessary field types
Date Sat, 05 Aug 2017 10:52:02 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115368#comment-16115368

Aditya Sharma edited comment on OFBIZ-9351 at 8/5/17 10:51 AM:

I think I just missed some traces in Birt so adding another patch for plugins.

was (Author: aditya.sharma):
I think I just missed some traces in Birt so adding another patch for plugins & reopening

> Remove unnecessary field types
> ------------------------------
>                 Key: OFBIZ-9351
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9351
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Trunk
>            Reporter: Aditya Sharma
>            Assignee: Deepak Dixit
>            Priority: Trivial
>             Fix For: Upcoming Release
>         Attachments: OFBIZ-9351.patch, OFBIZ-9351.patch, OFBIZ-9351_plugins.patch, OFBIZ-9351_plugins.patch
> As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty" field types
 ("id-ne", "id-long-ne" and  "id-vlong-ne") were initially added to implement validations
on data. But, because the validations where only implemented in some place like webtools,
it contradicts the distinction to be upheld on various layers. So it is better to remove these
field types. So we will remove all those field types and will create sub tickets to replace
them in entity definitions by corresponding "id" types.
> When replacing the "not empty" field types in entity definitions by corresponding "id"
types we will add a *not-null="true"* attribute to "makes the field NOT NULL on the database
(like primary key fields)" as explained in "not-null" documentation in fieldtypemodel.xsd.
 We will finally clean the documentation of the "not-null" in fieldtypemodel.xsd.
> Related Links:
> http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
> http://markmail.org/message/otec62xiwkpjttkq
> A more vivid description:
> http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k

This message was sent by Atlassian JIRA

View raw message