ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Le Roux (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-9306) Check there are no white spaces around the name of a form field when updating a form
Date Mon, 14 Aug 2017 17:11:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-9306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125990#comment-16125990
] 

Jacques Le Roux commented on OFBIZ-9306:
----------------------------------------

Thanks Michael,

Why do you think introducing a check for null should be done now? Is it related to this change
or in general (as it's now in trunk)?

I'm not sure it's needed because this change is only removing white-spaces around the name.
If the name is already empty I guess it's already handled with current code.

This said I'm not against checking for null first, I just want to understand why and maybe
where in code (I guess you mean just before the return, right?)

> Check there are no white spaces around the name of a form field when updating a form
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-9306
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9306
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL APPLICATIONS
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Upcoming Release
>
>         Attachments: OFBIZ-9306-ModelFormField.java.patch
>
>
> Sometimes ago, I lost an hour because of a space at the end of a field's name in a form.
In creation it does not pass (the field lacks) but when updating the form it passes and it's
hard to find from where comes the problem.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message