ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Le Roux (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-9138) Create a common theme
Date Fri, 25 Aug 2017 16:06:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141809#comment-16141809
] 

Jacques Le Roux commented on OFBIZ-9138:
----------------------------------------

Thanks Nicolas,

This is quite an achievement! 

Just that we have an issue with scrum tests https://ci.apache.org/projects/ofbiz/logs/trunk/html/
I checked locally it's the same.
We know the scrum does not always follow the best practices, so it could be that we need to
improve the code or even the tests there...

> Create a common theme
> ---------------------
>
>                 Key: OFBIZ-9138
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9138
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework
>            Reporter: Nicolas Malin
>            Assignee: Nicolas Malin
>         Attachments: common-theme-macro.svg, common-theme-screen.svg
>
>
> A first task to UI Improvement would be create a common that receive the existent code.
> The benefice would be have a framework/common who list all screens that available for
theme surcharge, so without technology information (css/html or something like that)
> Different task to do :
> * move all ftl template from framework/common to themes/common
> * move framework/images to themes/common (this directory contains unlogical element for
theme but will be manage at a second time)
> * move default macro ftl template from framework/widget to themes/common 
> After the realization on this task, all current themes call theme/common for html rendering
instead of framework/common, framework/images and framework/widget. Just pave the way for
the next



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message