Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0703D200CCA for ; Wed, 5 Jul 2017 00:20:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 053B916201E; Tue, 4 Jul 2017 22:20:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4B2B216201D for ; Wed, 5 Jul 2017 00:20:09 +0200 (CEST) Received: (qmail 37095 invoked by uid 500); 4 Jul 2017 22:20:08 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 37086 invoked by uid 99); 4 Jul 2017 22:20:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Jul 2017 22:20:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id DF0B0C0A0B for ; Tue, 4 Jul 2017 22:20:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.211 X-Spam-Level: X-Spam-Status: No, score=-99.211 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id fYpKZlY751mC for ; Tue, 4 Jul 2017 22:20:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 8902D5FCD2 for ; Tue, 4 Jul 2017 22:20:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B06D7E0D7E for ; Tue, 4 Jul 2017 22:20:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0C6DD24618 for ; Tue, 4 Jul 2017 22:20:03 +0000 (UTC) Date: Tue, 4 Jul 2017 22:20:03 +0000 (UTC) From: "Michael Brohl (JIRA)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (OFBIZ-9445) ContentWorker#findAlternateLocaleContent(Delegator, GenericValue, Locale) does not use fallback locale MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 04 Jul 2017 22:20:10 -0000 [ https://issues.apache.org/jira/browse/OFBIZ-9445?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1607= 4098#comment-16074098 ]=20 Michael Brohl commented on OFBIZ-9445: -------------------------------------- [~tlaufkoetter], I have reverted the commits because they introduced bug, s= ee OFBIZ-9446. > ContentWorker#findAlternateLocaleContent(Delegator, GenericValue, Locale)= does not use fallback locale > -------------------------------------------------------------------------= ----------------------------- > > Key: OFBIZ-9445 > URL: https://issues.apache.org/jira/browse/OFBIZ-9445 > Project: OFBiz > Issue Type: Bug > Components: content > Affects Versions: Trunk > Reporter: Tobias Laufk=C3=B6tter > Assignee: Michael Brohl > Fix For: 16.11.04 > > Attachments: OFBIZ-9445.patch, OFBIZ-9445v2.patch, OFBIZ-9445v3.p= atch > > > Contrary to the UiLabels the ContentWorker#findAlternateLocaleContent(Del= egator, GenericValue, Locale) function does not default to the fallback loc= ale if no alternate content with the given locale is found, but returns the= originial content. This proves to be an issue, if the root content is not = in the fallback language. > For instance: if the fallback locale is set to english, the ProductConten= t for the PRODUCT_NAME is in german, the alternate locale contents for the = product name are english and spanish, then an italian visitor will see the = page in english, but the product names in german. > A fix for this issue is simple: > If no alternate locale content for the requested locale is found, search = for an alternate locale content with the locale configured in general.prope= rties at locale.properties.fallback. If this one isn't found either we can = still return the original content. -- This message was sent by Atlassian JIRA (v6.4.14#64029)