Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 09734200CC0 for ; Sun, 9 Jul 2017 13:14:06 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 07F2816B80F; Sun, 9 Jul 2017 11:14:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4EE2216B806 for ; Sun, 9 Jul 2017 13:14:05 +0200 (CEST) Received: (qmail 285 invoked by uid 500); 9 Jul 2017 11:14:04 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 276 invoked by uid 99); 9 Jul 2017 11:14:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 09 Jul 2017 11:14:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 20F5C1A5F0E for ; Sun, 9 Jul 2017 11:14:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id hEexs16vSiw1 for ; Sun, 9 Jul 2017 11:14:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id B687F5F60D for ; Sun, 9 Jul 2017 11:14:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6F90BE0D51 for ; Sun, 9 Jul 2017 11:14:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2F2D624695 for ; Sun, 9 Jul 2017 11:14:00 +0000 (UTC) Date: Sun, 9 Jul 2017 11:14:00 +0000 (UTC) From: "Jacques Le Roux (JIRA)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Reopened] (OFBIZ-9404) Insufficient checking of checkOutPaymentId in CheckOutEvents.getSelectedPaymentMethods MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sun, 09 Jul 2017 11:14:06 -0000 [ https://issues.apache.org/jira/browse/OFBIZ-9404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-9404: ------------------------------------ Bac > Insufficient checking of checkOutPaymentId in CheckOutEvents.getSelectedPaymentMethods > -------------------------------------------------------------------------------------- > > Key: OFBIZ-9404 > URL: https://issues.apache.org/jira/browse/OFBIZ-9404 > Project: OFBiz > Issue Type: Bug > Components: order > Affects Versions: Trunk > Reporter: Martin Becker > Assignee: Arun Patidar > Fix For: 16.11.04 > > Attachments: OFBIZ-9404_empty-check_checkOutPaymentId.patch > > > The following patch fixes a bug where the paymentMethod in CheckOutEvents.getSelectedPaymentMethods might be filled with a phantom payment method. > It checks for an empty parameter, not only NULL, to avoid a phantom paymentMethod with ID "" in selectedPaymentMethods, that causes subsequent errors in payment handling (e.g. ShoppingCart.getValueObject). -- This message was sent by Atlassian JIRA (v6.4.14#64029)