Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5BDB1200CDC for ; Sat, 22 Jul 2017 09:12:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5A61116AFA9; Sat, 22 Jul 2017 07:12:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A138B16AF94 for ; Sat, 22 Jul 2017 09:12:03 +0200 (CEST) Received: (qmail 54883 invoked by uid 500); 22 Jul 2017 07:12:02 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 54864 invoked by uid 99); 22 Jul 2017 07:12:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 22 Jul 2017 07:12:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 646DFC0143 for ; Sat, 22 Jul 2017 07:12:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id KtTre0YXrXrW for ; Sat, 22 Jul 2017 07:12:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 1970D5FCC7 for ; Sat, 22 Jul 2017 07:12:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5614BE05BF for ; Sat, 22 Jul 2017 07:12:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0FC6521EE2 for ; Sat, 22 Jul 2017 07:12:00 +0000 (UTC) Date: Sat, 22 Jul 2017 07:12:00 +0000 (UTC) From: "Ashish Vijaywargiya (JIRA)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Assigned] (OFBIZ-9281) Code Improvement on Product Config MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 22 Jul 2017 07:12:04 -0000 [ https://issues.apache.org/jira/browse/OFBIZ-9281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Vijaywargiya reassigned OFBIZ-9281: ------------------------------------------ Assignee: Ashish Vijaywargiya (was: Suraj Khurana) > Code Improvement on Product Config > ---------------------------------- > > Key: OFBIZ-9281 > URL: https://issues.apache.org/jira/browse/OFBIZ-9281 > Project: OFBiz > Issue Type: Improvement > Components: product > Affects Versions: Trunk > Reporter: Suraj Khurana > Assignee: Ashish Vijaywargiya > Priority: Minor > Attachments: OFBIZ-9281.patch > > > I noticed a couple of code improvements on product config current code. Here is the reference: > - In ProductConfigWorker.fillProductConfigWrapper() method, currently, we only check parameters map, while it is possible in a business environment that user can submit required fields values in request attributes as well. So here getCombinedMap method can be used to make it more efficient. > - While calling constructor of ConfigOption (ConfigOption(ConfigOption co)), some private members should also be copied, like componentOptions etc. -- This message was sent by Atlassian JIRA (v6.4.14#64029)