ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kyra Pritzel-Hentley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-9505) [FB] Package org.apache.ofbiz.accounting.ledger
Date Fri, 21 Jul 2017 11:00:02 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-9505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096133#comment-16096133
] 

Kyra Pritzel-Hentley commented on OFBIZ-9505:
---------------------------------------------

Hello Pranay Pandey,

Thank you for the hints. I haven't written that much of a summary since this ticket describes
bugs found by a code analysis tool. The parent ticket gives a further description of what
is being done here. I don't quite know how I would go about describing how to generate the
issue since I am only looking at the code.  Do you have any suggestions for this? 

I will read the best practices guide. Thank you!

> [FB] Package org.apache.ofbiz.accounting.ledger
> -----------------------------------------------
>
>                 Key: OFBIZ-9505
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9505
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: Trunk
>            Reporter: Kyra Pritzel-Hentley
>            Priority: Minor
>
> The following Bugs were found by the FindBugs Software:
> GeneralLedgerServices.java:42, DLS_DEAD_LOCAL_STORE
> * DLS: Dead store to totalAmountPercentage in org.apache.ofbiz.accounting.ledger.GeneralLedgerServices.createUpdateCostCenter(DispatchContext,
Map)
> This instruction assigns a value to a local variable, but the value is not read or used
in any subsequent instruction. Often, this indicates an error, because the value computed
is never used.
> Note that Sun's javac compiler often generates dead stores for final local variables.
Because FindBugs is a bytecode-based tool, there is no easy way to eliminate these false positives.
> GeneralLedgerServices.java:50, WMI_WRONG_MAP_ITERATOR
> * WMI: org.apache.ofbiz.accounting.ledger.GeneralLedgerServices.createUpdateCostCenter(DispatchContext,
Map) makes inefficient use of keySet iterator instead of entrySet iterator
> This method accesses the value of a Map entry, using a key that was retrieved from a
keySet iterator. It is more efficient to use an iterator on the entrySet of the map, to avoid
the Map.get(key) lookup.
> GeneralLedgerServices.java:73, WMI_WRONG_MAP_ITERATOR
> * WMI: org.apache.ofbiz.accounting.ledger.GeneralLedgerServices.calculateCostCenterTotal(Map)
makes inefficient use of keySet iterator instead of entrySet iterator
> This method accesses the value of a Map entry, using a key that was retrieved from a
keySet iterator. It is more efficient to use an iterator on the entrySet of the map, to avoid
the Map.get(key) lookup.
> GeneralLedgerServices.java:75, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE
> * RCN: Redundant nullcheck of rowValue, which is known to be non-null in org.apache.ofbiz.accounting.ledger.GeneralLedgerServices.calculateCostCenterTotal(Map)
> This method contains a redundant check of a known non-null value against the constant
null.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message