ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taher Alkhateeb (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (OFBIZ-9441) Refactor OFBiz containers and remove StartupCommandToArgsAdapter
Date Fri, 21 Jul 2017 14:17:00 GMT

     [ https://issues.apache.org/jira/browse/OFBIZ-9441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Taher Alkhateeb updated OFBIZ-9441:
-----------------------------------
    Attachment: OFBIZ-9441.patch

Attaching newest patch which in addition to everything above does:
- Rename a few methods for better clarity
- Minor code refactoring
- Fixed a bug in which the filter stream for constructing the properties map is incorrect
(I applied the filter in reverse). Now it works perfectly and I tested it with multiple different
combos of commands on the command line. Essentially the bug was getting .equals() function
against an enum which is wrong. It should be the enum .toString() instead.

> Refactor OFBiz containers and remove StartupCommandToArgsAdapter
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-9441
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9441
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Taher Alkhateeb
>            Assignee: Taher Alkhateeb
>            Priority: Minor
>         Attachments: OFBIZ-9411.patch, OFBIZ-9441-fix-continue-on-failure.patch, OFBIZ-9441.patch,
OFBIZ-9441.patch, OFBIZ-9441.patch
>
>
> We have already refactored the ComponentContainer and CatalinaContainer in OFBIZ-8337
and OFBIZ-9392. The objective of this JIRA is to apply the following:
> - Refactor EntityDataLoadContainer to simplify the code and remove dependencies on "args"
and convert instead the logic to use StartupCommands
> - Refactor TestRunContainer the same way
> - Delete the class StartupCommandToArgsAdapter
> - Update README.md to reflect the changes and updates and cleanup old references.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message