ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taher Alkhateeb (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (OFBIZ-9441) Refactor OFBiz containers and remove StartupCommandToArgsAdapter
Date Mon, 10 Jul 2017 18:58:02 GMT

     [ https://issues.apache.org/jira/browse/OFBIZ-9441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Taher Alkhateeb updated OFBIZ-9441:
-----------------------------------
    Attachment: OFBIZ-9441-fix-continue-on-failure.patch

Okay, I figured out after a lot of digging what's going on. The culprit is the EntitySaxReader
which is acting as the DefaultHandler for the input, and in the function StartElement it is
swallowing an exception exactly here:

{code}
try {
    currentValue = delegator.makeValue(entityName);
    // TODO: do we really want this? it makes it so none of the values imported have create/update
timestamps set
    // DEJ 10/16/04 I think they should all be stamped, so commenting this out
    // JAZ 12/10/04 I think it should be specified when creating the reader
    if (this.maintainTxStamps) {
        currentValue.setIsFromEntitySync(true);
    }
} catch (Exception e) {
    Debug.logError(e, module);
}
{code}

I'm adding this attachment as a reference to where the problem exactly is and how I solved
it. I will soon add a new patch that includes everything

> Refactor OFBiz containers and remove StartupCommandToArgsAdapter
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-9441
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9441
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Taher Alkhateeb
>            Assignee: Taher Alkhateeb
>            Priority: Minor
>         Attachments: OFBIZ-9411.patch, OFBIZ-9441-fix-continue-on-failure.patch
>
>
> We have already refactored the ComponentContainer and CatalinaContainer in OFBIZ-8337
and OFBIZ-9392. The objective of this JIRA is to apply the following:
> - Refactor EntityDataLoadContainer to simplify the code and remove dependencies on "args"
and convert instead the logic to use StartupCommands
> - Refactor TestRunContainer the same way
> - Delete the class StartupCommandToArgsAdapter
> - Update README.md to reflect the changes and updates and cleanup old references.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message