ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taher Alkhateeb (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (OFBIZ-9441) Refactor OFBiz containers and remove StartupCommandToArgsAdapter
Date Mon, 10 Jul 2017 11:03:00 GMT

     [ https://issues.apache.org/jira/browse/OFBIZ-9441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Taher Alkhateeb updated OFBIZ-9441:
-----------------------------------
    Attachment: OFBIZ-9411.patch

This is a major refactoring patch that applies the following changes:


- Fully refactor both containers by breaking up the logic into many smaller
  methods which substantially improves the code readability.
- Remove most old documentation and commented out code where applicable
- Refactor both the test and data-load containers to reply on OFBiz commands
  instead of the old String array.
- Delete the StratupCommandToArgsAdapter as it is no longer needed
- Create a new feature in which OFBiz by default fails if any data file
  fails to load. This can be overridden by passing a flag called
  "continue-on-failure" e.g. ./gradlew "ofbiz --load-data continue-on-failure"
- Add a new property to --test called "loglevel" (old code but working properly)
- Add many new properties to the --load-data command including repair-columns,
  try-inserts, maintain-txs, etc ...
- Update the documentation output of ./gradlew "ofbiz --help" to incorporate
  the new mentioned properties
- Refactor README.md to incorporate the changes to the gradle commands for both
  "--load-data" and "--test" properties. Also remove the gradle GUI
  documentation as it is now deprecated.
- Also refactor README.md in other locations to cleanup and make it more
  consistent. This icludes moving long notes into new sections and reducing
  the verbosity of the security header. Furthermore, created a new header
  called Miscellaneous documentation to house the newly created sections
- lots of small changes to remove EOL white space

This patch requires a lot of testing ,especially the use of the properties in
different combinations to make sure all combinations work correctly. There were
many properties for the --load-data command that are added but probably not
used for a long time. I am not sure if this old code is relevant anymore, but I
revived it anyway. Testing is the final judge on its merit.

> Refactor OFBiz containers and remove StartupCommandToArgsAdapter
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-9441
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9441
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Taher Alkhateeb
>            Assignee: Taher Alkhateeb
>            Priority: Minor
>         Attachments: OFBIZ-9411.patch
>
>
> We have already refactored the ComponentContainer and CatalinaContainer in OFBIZ-8337
and OFBIZ-9392. The objective of this JIRA is to apply the following:
> - Refactor EntityDataLoadContainer to simplify the code and remove dependencies on "args"
and convert instead the logic to use StartupCommands
> - Refactor TestRunContainer the same way
> - Delete the class StartupCommandToArgsAdapter
> - Update README.md to reflect the changes and updates and cleanup old references.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message