ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nicolas Malin (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (OFBIZ-9138) Create a common theme
Date Fri, 28 Jul 2017 20:45:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105634#comment-16105634
] 

Nicolas Malin edited comment on OFBIZ-9138 at 7/28/17 8:44 PM:
---------------------------------------------------------------

It's now done, the common theme support the common screen redirection to the theme.

For the session problem, I force to load the user pref at the looking. The single problem
with that, if you change your theme on a webapp, it's currently not change in your others
open sessions.
In other word, if you have a browser tab in party and an other in product, if you change your
theme the tab open with a party session, your product session keep your old preference. To
reset it you need to logout from product. At this time I consider this as minor.

So we can by theme surcharge :
* widget properties
* ftl template macro
* common screen
And I detect no regression. So if you want to play with it, it's the time ! :)

source code: https://github.com/nmalin/ofbiz-framework/tree/common-theme
compare with trunk: https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1


was (Author: soledad):
It's now done, the common theme support the common screen redirection to the theme.

For the session problem, I force to load the user pref at the looking. The single problem
with that, if you change your theme on a webapp, it's currently not change in your others
open sessions.
In other word, if you have a browser tab in party and an other in product, if you change your
theme the tab open with a party session, your product session keep your old preference. To
reset it you need to logout from product. At this time I consider this as minor.

So we can by theme surcharge :
* widget properties
* ftl template macro
* common screen
And I detect no regression. So if you want to play with it, it's the time ! :)

> Create a common theme
> ---------------------
>
>                 Key: OFBIZ-9138
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9138
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework
>            Reporter: Nicolas Malin
>            Assignee: Nicolas Malin
>
> A first task to UI Improvement would be create a common that receive the existent code.
> The benefice would be have a framework/common who list all screens that available for
theme surcharge, so without technology information (css/html or something like that)
> Different task to do :
> * move all ftl template from framework/common to themes/common
> * move framework/images to themes/common (this directory contains unlogical element for
theme but will be manage at a second time)
> * move default macro ftl template from framework/widget to themes/common 
> After the realization on this task, all current themes call theme/common for html rendering
instead of framework/common, framework/images and framework/widget. Just pave the way for
the next



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message