Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ofbiz.apache.org
Date: Tue, 27 Jun 2017 17:14:00 +0000 (UTC)
From: "Taher Alkhateeb (JIRA)" <jira@apache.org>
To: notifications@ofbiz.apache.org
Message-ID: <JIRA.13082840.1498575642000.116963.1498583640364@Atlassian.JIRA>
In-Reply-To: <JIRA.13082840.1498575642000@Atlassian.JIRA>
References: <JIRA.13082840.1498575642000@Atlassian.JIRA> <JIRA.13082840.1498575642738@jira-lw-us.apache.org>
Subject: [jira] [Comment Edited] (OFBIZ-9435) Refactor Config.java and
 properties files
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 27 Jun 2017 17:14:07 -0000


    [ https://issues.apache.org/jira/browse/OFBIZ-9435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065145#comment-16065145 ] 

Taher Alkhateeb edited comment on OFBIZ-9435 at 6/27/17 5:13 PM:
-----------------------------------------------------------------

The answer for both questions is that I think it's better to keep the comments so that people know what will happen if something is commented out and what will happen if not.

If we are going to remove the comments for load-data and test, then we should perhaps remove _all_ comments and keep them in start. Otherwise I think we should have the same file structure for all properties files for consistency's sake. I don't have a strong opinion either way, but I do prefer to have either all or none as far as comments are concerned.


was (Author: taher):
The answer for both questions is that I think it's better to keep the comments so that people know what will happen if something is commented out and what will happen if not.

If we are going to remove the comments for load-data and test, then we should perhaps remove _all_ comments and keep them in start. Otherwise I think we should have the same file structure for all properties files for consistency's sake.

> Refactor Config.java and properties files
> -----------------------------------------
>
>                 Key: OFBIZ-9435
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9435
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Taher Alkhateeb
>            Assignee: Taher Alkhateeb
>            Priority: Minor
>         Attachments: OFBIZ-9435.patch
>
>
> Apply further refactoring in the start component by reducing some complex logic. Patch will be provided momentarily


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)