Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5A594200CB4 for ; Tue, 27 Jun 2017 19:04:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 58BAA160BDC; Tue, 27 Jun 2017 17:04:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9F360160BD8 for ; Tue, 27 Jun 2017 19:04:03 +0200 (CEST) Received: (qmail 33911 invoked by uid 500); 27 Jun 2017 17:04:02 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 33902 invoked by uid 99); 27 Jun 2017 17:04:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Jun 2017 17:04:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 50F7ACA8D7 for ; Tue, 27 Jun 2017 17:04:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.211 X-Spam-Level: X-Spam-Status: No, score=-99.211 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id KRfBdvx9k6P9 for ; Tue, 27 Jun 2017 17:04:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 0D94A5FBBA for ; Tue, 27 Jun 2017 17:04:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4DEE0E03EE for ; Tue, 27 Jun 2017 17:04:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0A9D62410F for ; Tue, 27 Jun 2017 17:04:00 +0000 (UTC) Date: Tue, 27 Jun 2017 17:04:00 +0000 (UTC) From: "Jacques Le Roux (JIRA)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (OFBIZ-9435) Refactor Config.java and properties files MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 27 Jun 2017 17:04:04 -0000 [ https://issues.apache.org/jira/browse/OFBIZ-9435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065139#comment-16065139 ] Jacques Le Roux commented on OFBIZ-9435: ---------------------------------------- Sounds good to me, nitpiky: since we don't need ofbiz.admin.key for load and test, do we need to keep bq. # Default ofbiz.admin.key NA in load-data.properties and test.properties. Same question for bq. #ofbiz.locale.default=en > Refactor Config.java and properties files > ----------------------------------------- > > Key: OFBIZ-9435 > URL: https://issues.apache.org/jira/browse/OFBIZ-9435 > Project: OFBiz > Issue Type: Improvement > Reporter: Taher Alkhateeb > Assignee: Taher Alkhateeb > Priority: Minor > Attachments: OFBIZ-9435.patch > > > Apply further refactoring in the start component by reducing some complex logic. Patch will be provided momentarily -- This message was sent by Atlassian JIRA (v6.4.14#64029)