ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taher Alkhateeb (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (OFBIZ-9435) Refactor Config.java and properties files
Date Tue, 27 Jun 2017 15:06:00 GMT

     [ https://issues.apache.org/jira/browse/OFBIZ-9435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Taher Alkhateeb updated OFBIZ-9435:
-----------------------------------
    Attachment: OFBIZ-9435.patch

This patch applies the following changes:

- change the default adminKey to "NA" since it is only used in the "start" context. Other
contexts do not require an admin server (test, load-data)
- Simplify and cleanup the locale creation logic in the constructor and move things out to
the method with a return value
- Simplify the Timezone creation logic by moving it outside the constructor into a small method
- Substantially simplify the determineOfbizPropertiesFileName(..) method by reversing the
order of condition evaluation (first, load-data, then test, then anything else is start)
- update the properties files accordingly

> Refactor Config.java and properties files
> -----------------------------------------
>
>                 Key: OFBIZ-9435
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9435
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Taher Alkhateeb
>            Assignee: Taher Alkhateeb
>            Priority: Minor
>         Attachments: OFBIZ-9435.patch
>
>
> Apply further refactoring in the start component by reducing some complex logic. Patch
will be provided momentarily



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message