ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Le Roux (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-9385) EntityListIterator closed but not in case of exception
Date Tue, 13 Jun 2017 08:31:00 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-9385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16047563#comment-16047563
] 

Jacques Le Roux commented on OFBIZ-9385:
----------------------------------------

I found some other cases and improved them at 1798566. I did not improve tests code, it's
has no real impact.

This completes OFBIZ-9385, there are no other cases left.

> EntityListIterator closed but not in case of exception
> ------------------------------------------------------
>
>                 Key: OFBIZ-9385
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9385
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Upcoming Release
>
>
> I found several cases. This is an improvement only because no cases were reported. But
obviously in case of unlucky exception after the EntityListIterator creation and before it's
closed the EntityListIterator remains in memory. It should be closed in EntityListIterator.finalize()
but the less happens there the better.
> The solution is to use try-with-ressources when (easily) possible (some cases are quite
convoluted)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message