Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ofbiz.apache.org
Date: Wed, 31 May 2017 17:18:04 +0000 (UTC)
From: "Jacques Le Roux (JIRA)" <jira@apache.org>
To: notifications@ofbiz.apache.org
Message-ID: <JIRA.13076243.1496250121000.333554.1496251084098@Atlassian.JIRA>
In-Reply-To: <JIRA.13076243.1496250121000@Atlassian.JIRA>
References: <JIRA.13076243.1496250121000@Atlassian.JIRA> <JIRA.13076243.1496250121115@jira-lw-us.apache.org>
Subject: [jira] [Commented] (OFBIZ-9385) EntityListIterator closed but not
 in case of exception
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 31 May 2017 17:18:08 -0000


    [ https://issues.apache.org/jira/browse/OFBIZ-9385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16031542#comment-16031542 ] 

Jacques Le Roux commented on OFBIZ-9385:
----------------------------------------

Done at revision: 1797074 for content

> EntityListIterator closed but not in case of exception
> ------------------------------------------------------
>
>                 Key: OFBIZ-9385
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9385
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Upcoming Release
>
>
> I found several cases. This is an improvement only because no cases were reported. But obviously in case of unlucky exception after the EntityListIterator creation and before it's closed the EntityListIterator remains in memory. It should be closed in EntityListIterator.finalize() but the less happens there the better.
> The solution is to use try-with-ressources when (easily) possible (some cases are quite convoluted)


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)