Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3442C200C82 for ; Sat, 27 May 2017 08:40:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 32ED3160BDA; Sat, 27 May 2017 06:40:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7B3AA160BC6 for ; Sat, 27 May 2017 08:40:07 +0200 (CEST) Received: (qmail 83250 invoked by uid 500); 27 May 2017 06:40:06 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 83239 invoked by uid 99); 27 May 2017 06:40:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 27 May 2017 06:40:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id EEB6F1A08B5 for ; Sat, 27 May 2017 06:40:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 4nxf9a6k00Jb for ; Sat, 27 May 2017 06:40:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 15BC85F5C6 for ; Sat, 27 May 2017 06:40:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 93046E0C0F for ; Sat, 27 May 2017 06:40:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3E7E221B59 for ; Sat, 27 May 2017 06:40:04 +0000 (UTC) Date: Sat, 27 May 2017 06:40:04 +0000 (UTC) From: "Deepak Dixit (JIRA)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (OFBIZ-9381) Convert RateServices.xml mini-lang to groovyDSL MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 27 May 2017 06:40:08 -0000 [ https://issues.apache.org/jira/browse/OFBIZ-9381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit updated OFBIZ-9381: -------------------------------- Issue Type: Sub-task (was: Task) Parent: OFBIZ-9350 > Convert RateServices.xml mini-lang to groovyDSL > ----------------------------------------------- > > Key: OFBIZ-9381 > URL: https://issues.apache.org/jira/browse/OFBIZ-9381 > Project: OFBiz > Issue Type: Sub-task > Components: accounting > Affects Versions: Trunk > Reporter: Nicolas Malin > Assignee: Nicolas Malin > Priority: Minor > Labels: groovy, mini-lang > Attachments: OFBIZ-9381.patch, OFBIZ-9381.patch > > > With the purpose to deprecate mini-lang OFBIZ-9350, I tried to convert some mini-lang service to groovy script. > I converted updateRateAmount, deleteRateAmount, updatePartyRate and deleteRateAmount. > Delete isn't a good definition for the service who expire the element instead of remove if. So I propose with the patch to move the deleteRateAmount and deletePartyRate to expireRateAmount and expirePartyRate. -- This message was sent by Atlassian JIRA (v6.3.15#6346)