Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ofbiz.apache.org
Date: Mon, 22 May 2017 08:25:05 +0000 (UTC)
From: "Jacques Le Roux (JIRA)" <jira@apache.org>
To: notifications@ofbiz.apache.org
Message-ID: <JIRA.13069920.1494234817000.260992.1495441505042@Atlassian.JIRA>
In-Reply-To: <JIRA.13069920.1494234817000@Atlassian.JIRA>
References: <JIRA.13069920.1494234817000@Atlassian.JIRA> <JIRA.13069920.1494234817221@jira-lw-us.apache.org>
Subject: [jira] [Issue Comment Deleted] (OFBIZ-9351) Remove unnecessary
 field types
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 22 May 2017 08:25:17 -0000


     [ https://issues.apache.org/jira/browse/OFBIZ-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-9351:
-----------------------------------
    Comment: was deleted

(was: Replaced fields with "id-ne", "id-long-ne" and "id-vlong-ne" with "id", "id-long" and "id-vlong" respectively which are primary keys. 
The patch also covers the field names like "parentTypeId" as it will always be empty for some record that starts the hierarchy.)

> Remove unnecessary field types
> ------------------------------
>
>                 Key: OFBIZ-9351
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9351
>             Project: OFBiz
>          Issue Type: Task
>            Reporter: Aditya Sharma
>            Assignee: Aditya Sharma
>            Priority: Trivial
>         Attachments: OFBIZ-9351.patch, OFBIZ-9351_plugins.patch
>
>
> As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty" field types  ("id-ne", "id-long-ne" and  "id-vlong-ne") were initially added to implement validations on data. But, because the validations where only implemented in some place like webtools, it contradicts the distinction to be upheld on various layers. So it is better to remove these field types. So we will remove all those field types and will create sub tickets to replace them in entity definitions by corresponding "id" types.
> When replacing the "not empty" field types in entity definitions by corresponding "id" types we will add a *not-null="true"* attribute to "makes the field NOT NULL on the database (like primary key fields)" as explained in "not-null" documentation in fieldtypemodel.xsd.  We will finally clean the documentation of the "not-null" in fieldtypemodel.xsd.
> Related Links:
> http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
> http://markmail.org/message/otec62xiwkpjttkq
> A more vivid description:
> http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)