ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Deepak Dixit (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-9381) Convert RateServices.xml mini-lang to groovyDSL
Date Sat, 27 May 2017 11:55:04 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-9381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027408#comment-16027408
] 

Deepak Dixit commented on OFBIZ-9381:
-------------------------------------

Thanks [~soledad], yes it looks good to me,

You can remove unused Debug class from import. :)


> Convert RateServices.xml mini-lang to groovyDSL
> -----------------------------------------------
>
>                 Key: OFBIZ-9381
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9381
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: Trunk
>            Reporter: Nicolas Malin
>            Assignee: Nicolas Malin
>            Priority: Minor
>              Labels: groovy, mini-lang
>         Attachments: OFBIZ-9381-1.patch, OFBIZ-9381.patch, OFBIZ-9381.patch
>
>
> With the purpose to deprecate mini-lang OFBIZ-9350, I tried to convert some mini-lang
service to groovy script.
> I converted updateRateAmount, deleteRateAmount, updatePartyRate and deleteRateAmount.
> Delete isn't a good definition for the service who expire the element instead of remove
if. So I propose with the patch to move the deleteRateAmount and deletePartyRate to expireRateAmount
and expirePartyRate.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message