ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aditya Sharma (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (OFBIZ-9351) Remove unnecessary field types
Date Sat, 20 May 2017 13:20:04 GMT

     [ https://issues.apache.org/jira/browse/OFBIZ-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Aditya Sharma updated OFBIZ-9351:
    Attachment: OFBIZ-9351.patch

Replace fields with "id-ne", "id-long-ne" and "id-vlong-ne" with "id", "id-long" and "id-vlong"
respectively which are primary keys. 
The patch also covers the field names like "parentTypeId" as it will always be empty for some
record that starts the hierarchy.

> Remove unnecessary field types
> ------------------------------
>                 Key: OFBIZ-9351
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9351
>             Project: OFBiz
>          Issue Type: Task
>            Reporter: Aditya Sharma
>            Assignee: Aditya Sharma
>            Priority: Trivial
>         Attachments: OFBIZ-9351.patch
> As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty" field types
 ("id-ne", "id-long-ne" and  "id-vlong-ne") were initially added to implement validations
on data. But, because the validations where only implemented in some place like webtools,
it contradicts the distinction to be upheld on various layers. So it is better to remove these
field types. So we will remove all those field types and will create sub tickets to replace
them in entity definitions by corresponding "id" types.
> When replacing the "not empty" field types in entity definitions by corresponding "id"
types we will add a *not-null="true"* attribute to "makes the field NOT NULL on the database
(like primary key fields)" as explained in "not-null" documentation in fieldtypemodel.xsd.
 We will finally clean the documentation of the "not-null" in fieldtypemodel.xsd.
> Related Links:
> http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
> http://markmail.org/message/otec62xiwkpjttkq
> A more vivid description:
> http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k

This message was sent by Atlassian JIRA

View raw message