ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Le Roux (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (OFBIZ-9346) Maximise utilisation of common labels in AccountingMenus.xml
Date Sun, 07 May 2017 21:00:05 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-9346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000065#comment-16000065
] 

Jacques Le Roux edited comment on OFBIZ-9346 at 5/7/17 8:59 PM:
----------------------------------------------------------------

To be pragmatic, a possibility is to simply (only) remove CommonTerms which is not used at
all and keep AccountingAgreementTerms and its uses... We already removed unused labels at
 OFBIZ-8154 which is still a WIP... 

I did not check the others (AccountingAgreementItems, AccountingAgreementRoles and AccountingAgreementContents)
but I see no reasons Michael's idea (specialisation vs generalisation) would not also applies
and we can close the 3 issues (OFBIZ-9346, OFBIZ-9348 and OFBIZ-9349). 

Agreed? (else we will keep another useless set of issues open).

So common labels should only be used when no specialisation at all is expected...




was (Author: jacques.le.roux):
To be pragmatic, a possibility is to remove CommonTerms which is not used at all and keep
AccountingAgreementTerms... We already removed unused labels at  OFBIZ-8154 which is still
a WIP... I still did not check the others (AccountingAgreementItems, AccountingAgreementRoles
and AccountingAgreementContents)...



> Maximise utilisation of common labels in AccountingMenus.xml
> ------------------------------------------------------------
>
>                 Key: OFBIZ-9346
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9346
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Assignee: Pierre Smits
>            Priority: Minor
>         Attachments: OFBIZ-9346-AccountingMenus-v2.patch, OFBIZ-9346-AccountingMenus.xml.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message