ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Le Roux (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1
Date Thu, 11 May 2017 08:59:04 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006114#comment-16006114
] 

Jacques Le Roux edited comment on OFBIZ-8316 at 5/11/17 8:58 AM:
-----------------------------------------------------------------

Thanks Cao Pengan, Jinghai, Michael,

The error I reported
bq. Error waiting for SolrCore to be created
I guess (as suggested by Jinghai) was fixed by OFBIZ-7265 (can't reproduce)

After reviewing  rev.1794770, 1794771 I tough see few reasons to keep this issue open, for
at least discussion.

Jinghai, do we really need to keep these commented out lines? https://s.apache.org/DTEG
Form your comment
bq. OFBiz-8316, the LongPoint should be reused when updating to Solr 6.4.1 or later
it seems not.

What about
{code}
-  <dataDir>${solr.data.dir:runtime/indexes/solr}</dataDir>
+  <dataDir>${ofbiz.home}/runtime/indexes/products/</dataDir>
{code}
Should we not put all under runtime/indexes/solr. So here runtime/indexes/solr/products? I
know it changes habits, so not sure.

I wonder if we should not rename "runtime/indexes/solr" to "runtime/indexes/solrAndLucene"
just to let know users that all Solr and Lucene indexes are there.

On the Solr admin UI, can't we remove the now confusing "Use original UI", since we only use
one now (not a big deal).

Ah Jinghai, I just noticed something trivial and very ASF formal. You say
bq. Thanks Cao Pengan for the new 6.5.1 patch!
But I don't see this patch. For me, it's not really an issue. But, following ASF rules, the
patch should have been attached by Cao Pengan before being committed by you ;)

+The idea is:+ it's the *person* who contribute who delegates her/his rights (copyright) to
the ASF. Of course if you did not have wrote this sentence I'd not know. I know other teams
(I guess you somehow works with Cao Pengan) are doing that (still not orthodox). Not a big
deal, more for you to know :)




was (Author: jacques.le.roux):
Thanks Cao Pengan, Jinghai, Michael,

The error I reported
bq. Error waiting for SolrCore to be created
I guess (as suggested by Jinghai) was fixed by OFBIZ-7265 (can't reproduce)

After reviewing  rev.1794770, 1794771 I tough see few reason to keep this issue open, for
at least discussion.

Jinghai, do we really need to keep these commented out lines? https://s.apache.org/DTEG
Form your comment
bq. OFBiz-8316, the LongPoint should be reused when updating to Solr 6.4.1 or later
it seems not.

What about
{code}
-  <dataDir>${solr.data.dir:runtime/indexes/solr}</dataDir>
+  <dataDir>${ofbiz.home}/runtime/indexes/products/</dataDir>
{code}
Should we not put all under runtime/indexes/solr. So here runtime/indexes/solr/products? I
know it changes habits, so not sure.

I wonder if we should not rename "runtime/indexes/solr" to "runtime/indexes/solrAndLucene"
just to let know users that all Solr and Lucene indexes are there.

On the Solr admin UI, can't we remove the now confusing "Use original UI", since we only use
it now (not a big deal).

Ah Jinghai, I just noticed something trivial and very ASF formal. You say
bq. Thanks Cao Pengan for the new 6.5.1 patch!
But I don't see this patch. For me, it's not really an issue. But, following ASF rules, the
patch should have been attached by Cao Pengan before being committed by you ;)

+The idea is:+ it's the *person* who contribute who delegates her/his rights (copyright) to
the ASF. Of course if you did not have wrote this sentence I'd not know. I know other teams
(I guess you somehow works with Cao Pengan) are doing that (still not orthodox). Not a big
deal, more for you to know :)



> Update Apache Solr/Lucene to release 6.2.1
> ------------------------------------------
>
>                 Key: OFBIZ-8316
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-8316
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: lucene, solr
>    Affects Versions: Trunk
>            Reporter: Michael Brohl
>            Assignee: Shi Jinghai
>            Priority: Minor
>         Attachments: OFBIZ-8316_corrected.patch, ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch,
solr6.2.1_1.patch
>
>
> According to the announcements in https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E
and https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E
there is a new Solr/Lucene release available.
> This issue takes care of the update.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message