ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Devanshu Vyas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-9254) Inconsistent String Comparisons
Date Fri, 21 Apr 2017 09:01:04 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978347#comment-15978347
] 

Devanshu Vyas commented on OFBIZ-9254:
--------------------------------------

Thanks Jacques, for your courageous efforts!! The patch file is really large...

And Thanks Deepak, for the suggestion and appreciate your help here.
I think I can break the patch at the component levels and then it will easy for you all to
review.

> Inconsistent String Comparisons
> -------------------------------
>
>                 Key: OFBIZ-9254
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9254
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Devanshu Vyas
>            Priority: Minor
>         Attachments: OFBIZ-9254_groovy.patch, OFBIZ-9254_java.patch
>
>
> I found an inconsistency in the code for string comparison statusId.equals("PRUN_COMPLETED")
whereas it should be written as "PRUN_COMPLETED".equals(statusId) 
> cause the former can throw NullPointerException if the variable found to be NULL.
> This pattern should be applied to 
> - Java Files
> - Groovy Files
> - FTL Files
> Here is the reference for the discussion done on the dev list.
> http://markmail.org/message/iqfaab3fl3ukxchy



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message