ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taher Alkhateeb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-9285) OFBiz Startup Message
Date Tue, 28 Mar 2017 15:57:41 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-9285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945435#comment-15945435
] 

Taher Alkhateeb commented on OFBIZ-9285:
----------------------------------------

Hi James,

I think the code should not be in the start method. It makes it not very readable with the
ASCII art. So the code should be isolated in a nice function that hides both the ASCII art
and the if condition. For example, you can create a method called printStartupMessageIfEnabled(Config
config) { // your code here } and call it from the start method.

> OFBiz Startup Message
> ---------------------
>
>                 Key: OFBIZ-9285
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9285
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Upcoming Release
>            Reporter: James Yong
>            Assignee: James Yong
>            Priority: Minor
>         Attachments: OFBIZ-9285.patch, OFBIZ-9285.v2.patch
>
>
> Provide log message to inform users that OFBiz has started. 
> This log message will show after all containers/components are loaded:
> {code}
> **************************************
> ** OFBiz is started and ready for use
> **************************************
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message