Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E349A200C06 for ; Thu, 12 Jan 2017 15:13:53 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id E10FB160B4F; Thu, 12 Jan 2017 14:13:53 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 36063160B4C for ; Thu, 12 Jan 2017 15:13:53 +0100 (CET) Received: (qmail 18169 invoked by uid 500); 12 Jan 2017 14:13:52 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 18105 invoked by uid 99); 12 Jan 2017 14:13:52 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Jan 2017 14:13:52 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 1942E2C03DF for ; Thu, 12 Jan 2017 14:13:52 +0000 (UTC) Date: Thu, 12 Jan 2017 14:13:52 +0000 (UTC) From: "Jacques Le Roux (JIRA)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Closed] (OFBIZ-9164) Refactor ContentWorkerInterface methods signatures MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 12 Jan 2017 14:13:54 -0000 [ https://issues.apache.org/jira/browse/OFBIZ-9164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9164. ---------------------------------- Resolution: Implemented > Refactor ContentWorkerInterface methods signatures > -------------------------------------------------- > > Key: OFBIZ-9164 > URL: https://issues.apache.org/jira/browse/OFBIZ-9164 > Project: OFBiz > Issue Type: Sub-task > Components: content, framework, order, party, product, specialpurpose/lucene, workeffort > Affects Versions: Trunk > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Priority: Minor > Fix For: Upcoming Release > > Attachments: OFBIZ-9164 DataResourceWorker.java.patch, OFBIZ-9164.patch > > > While working on OFBIZ-6919 which was built on R13.07 I stumbled upon an issue due to r1652852 where Adrian improved the cacheKey in FormFactory.getFormFromLocation() by adding a delegator reference (Tenants). Actually I'm not even sure it was done at r1652852 because Adrian did not maintain the FormFactory svn history. > Anyway, to make a long story short I had to introduce a DispatchContext parameter when calling FormFactory.readFormDocument() when the code from R13.07 only passed a null. > This had an impact in the hierarchy tree because FormFactory.readFormDocument() was called in DataResourceWorker class, where the new code was called from renderDataResourceAsText(). So I instead of only passing a Delegator I decided to pass only a LocalDispatcher parameter in renderDataResourceAsText(), since we can get the Delegator from the LocalDispatcher. Doing so it had an impact on the renderDataResourceAsText hierarchy tree ending in DataResourceWorkerInterface and all related. > I finally decided to apply the same ["Change Method Signature" refactoring pattern|http://refactoring.com/catalog/addParameter.html] to all cases related to ContentWorkerInterface. No need to pass a delegator when you have LocalDispatcher! > Here I attach a patch for review, I'll commit in few days -- This message was sent by Atlassian JIRA (v6.3.4#6332)