Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CA2F9200BE8 for ; Thu, 8 Dec 2016 13:57:11 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id C8A92160B27; Thu, 8 Dec 2016 12:57:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1D4D4160B1E for ; Thu, 8 Dec 2016 13:57:10 +0100 (CET) Received: (qmail 84707 invoked by uid 500); 8 Dec 2016 12:57:09 -0000 Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ofbiz.apache.org Delivered-To: mailing list notifications@ofbiz.apache.org Received: (qmail 84420 invoked by uid 99); 8 Dec 2016 12:56:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Dec 2016 12:56:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 876AC2C0079 for ; Thu, 8 Dec 2016 12:56:58 +0000 (UTC) Date: Thu, 8 Dec 2016 12:56:58 +0000 (UTC) From: "Nicolas Malin (JIRA)" To: notifications@ofbiz.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (OFBIZ-9138) Create a common theme MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 08 Dec 2016 12:57:12 -0000 [ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15732136#comment-15732136 ] Nicolas Malin commented on OFBIZ-9138: -------------------------------------- I continue the work with : * with move macro ftl on common-theme * move uneeded properties from widget.properties commonWidget.properties present on common-theme to keep on first properties file only property related to widget model and not widget rendering * review some code on FindAutocompleteOptions.groovy and MacroFormRenderer.java to move rendering property use to FtlMacro or decorator screen POC available on https://github.com/nmalin/ApacheOFBiz/tree/common-theme > Create a common theme > --------------------- > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework > Reporter: Nicolas Malin > Assignee: Nicolas Malin > > A first task to UI Improvement would be create a common that receive the existent code. > The benefice would be have a framework/common who list all screens that available for theme surcharge, so without technology information (css/html or something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for html rendering instead of framework/common, framework/images and framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.3.4#6332)