ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Le Roux (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-7680) Attribute 'value-field' must appear on element 'entity-one'
Date Sun, 11 Dec 2016 17:58:58 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15740092#comment-15740092
] 

Jacques Le Roux commented on OFBIZ-7680:
----------------------------------------

At OFBIZ-8203, after Florian discovered that when no value-field is set then OFBiz put the
Entity fields values directly in context, I said
{quote}
Thanks Florian, I confirm this behaviour. Since this works, now there are 2 possibilities.

* We fix all the existing cases by adding missing value-field values
* We no longer make the value-field attribute required and document this possibility in the
XSD

Both solutions are easy and can be done one after the other. I'd prefer the 2nd because having
a default value is always welcome (conventions over configuration). But because of consistency,
I'd have to check that entity-one in Minilang behaves the same. If it does not then there
are again 2 possibilities.

* We only fix all the existing cases by adding missing value-field values in widgets actions
* After doing the 2nd point above we also make the value-field attribute no longer required
and document this possibility in the XSD. 

Since I don't know what doing the same in Minilang entails. I'll simply doing the 1s point
and will ask the community what they think about it.
{quote}

I just checked and of course Minilang does not behave the same. So I'll ask community opinion
before changing anything.

> Attribute 'value-field' must appear on element 'entity-one'
> -----------------------------------------------------------
>
>                 Key: OFBIZ-7680
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7680
>             Project: OFBiz
>          Issue Type: Bug
>          Components: content, humanres
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>
> I found these errors
> cvc-complex-type.4: Attribute 'value-field' must appear on element 'entity-one'.	CompDocTemplateTree.xml
/ofbiz/applications/content/widget/compdoc	line 25
> cvc-complex-type.4: Attribute 'value-field' must appear on element 'entity-one'.	CompDocTemplateTree.xml
/ofbiz/applications/content/widget/compdoc	line 57
> cvc-complex-type.4: Attribute 'value-field' must appear on element 'entity-one'.	CompDocTemplateTree.xml
/ofbiz/applications/content/widget/compdoc	line 93
> cvc-complex-type.4: Attribute 'value-field' must appear on element 'entity-one'.	CompDocTemplateTree.xml
/ofbiz/applications/content/widget/compdoc	line 125
> cvc-complex-type.4: Attribute 'value-field' must appear on element 'entity-one'.	ContentForms.xml
/ofbiz/applications/content/widget/content	line 235
> cvc-complex-type.4: Attribute 'value-field' must appear on element 'entity-one'.	ContentSetupForms.xml
/ofbiz/applications/content/widget/contentsetup	line 217
> cvc-complex-type.4: Attribute 'value-field' must appear on element 'entity-one'.	EmploymentAppForms.xml
/ofbiz/applications/humanres/widget/forms	line 27
> cvc-complex-type.4: Attribute 'value-field' must appear on element 'entity-one'.	PayGradeForms.xml
/ofbiz/applications/humanres/widget/forms	line 65



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message