Return-Path: <notifications-return-6407-archive-asf-public=cust-asf.ponee.io@ofbiz.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 545C2200BE3
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu, 17 Nov 2016 04:38:00 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 52D47160B08; Thu, 17 Nov 2016 03:38:00 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 9E94A160B13
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 17 Nov 2016 04:37:59 +0100 (CET)
Received: (qmail 45615 invoked by uid 500); 17 Nov 2016 03:37:58 -0000
Mailing-List: contact notifications-help@ofbiz.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:notifications-help@ofbiz.apache.org>
List-Unsubscribe: <mailto:notifications-unsubscribe@ofbiz.apache.org>
List-Post: <mailto:notifications@ofbiz.apache.org>
List-Id: <notifications.ofbiz.apache.org>
Reply-To: dev@ofbiz.apache.org
Delivered-To: mailing list notifications@ofbiz.apache.org
Received: (qmail 45586 invoked by uid 99); 17 Nov 2016 03:37:58 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Nov 2016 03:37:58 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 682952C0088
	for <notifications@ofbiz.apache.org>; Thu, 17 Nov 2016 03:37:58 +0000 (UTC)
Date: Thu, 17 Nov 2016 03:37:58 +0000 (UTC)
From: "Paul Foxworthy (JIRA)" <jira@apache.org>
To: notifications@ofbiz.apache.org
Message-ID: <JIRA.13020518.1479135964000.300162.1479353878422@Atlassian.JIRA>
In-Reply-To: <JIRA.13020518.1479135964000@Atlassian.JIRA>
References: <JIRA.13020518.1479135964000@Atlassian.JIRA> <JIRA.13020518.1479135964920@arcas>
Subject: [jira] [Commented] (OFBIZ-9117) EntityAuto engine override the
 passed service in parameters
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Thu, 17 Nov 2016 03:38:00 -0000


    [ https://issues.apache.org/jira/browse/OFBIZ-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15672583#comment-15672583 ] 

Paul Foxworthy commented on OFBIZ-9117:
---------------------------------------

Hi Deepak and Jacques,

I think the problem is in the definition of the createInvoiceContactMech Service:

    <service name="createInvoiceContactMech" engine="entity-auto" invoke="create" default-entity-name="InvoiceContactMech">
        <description>Create a ContactMech for an invoice</description>
        <permission-service service-name="acctgInvoicePermissionCheck" main-action="CREATE"/>
        <auto-attributes include="pk" mode="IN" optional="false"/>
        <attribute name="contactMechId" type="String" mode="OUT" optional="true"/>
    </service>

Why the "OUT" on the contactMechId? The service should *not* be generating a new contactMechId, it's an input to associate an existing ContactMech with the invoice.

If we delete the line  <attribute name="contactMechId" type="String" mode="OUT" optional="true"/>, will everything then work? I think so.

> EntityAuto engine override the passed service in parameters
> -----------------------------------------------------------
>
>                 Key: OFBIZ-9117
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9117
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Deepak Dixit
>         Attachments: errorlog.txt
>
>
> There is an bug in EntityAuto engine, it override the passed service in parameters. 
> In createInvoiceForOrder service calls the createInvoiceContactMech to crate invoice contactMech for PAYMENT_LOCATION purpose (at line no 357). In case of SO it should use Company PAYMENT_LOCATION contactMech. It get the Company contactMechId correctly and set it createInvoiceContactMech service in context correctly, but system throws foreign key constraints error for incorrect contactMechId. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)