ofbiz-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Scott Gray (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OFBIZ-7366) FTL formatting in the whole application
Date Mon, 21 Nov 2016 20:14:58 GMT

    [ https://issues.apache.org/jira/browse/OFBIZ-7366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15684596#comment-15684596

Scott Gray commented on OFBIZ-7366:

I'm sorry I haven't commented sooner, I hadn't seen the tickets until now.  IMO the best way
to format Freemarker template is to have separate indentation for ftl markup vs. html (or
whatever language is being templated).  I strongly believe this is the best approach for readability.
 Our current approach often leads to the html being incorrectly indented after being rendered
and it is very difficult to discern the html structure when reading the template.

Let me know if there is any interest in this approach and I can provide a few patches of modified
files to highlight how much better it is.

> FTL formatting in the whole application
> ---------------------------------------
>                 Key: OFBIZ-7366
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7366
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL APPLICATIONS
>            Reporter: Vaibhav Jain
>            Assignee: Vaibhav Jain
> There is a formatting issue in the most of FTL files in OFBiz.
> We need to format the code as per best practice to make it more readable.

This message was sent by Atlassian JIRA

View raw message